Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: [WIP] @pixi/react v8 #490

Closed
wants to merge 18 commits into from
Closed

feat: [WIP] @pixi/react v8 #490

wants to merge 18 commits into from

Conversation

trezy
Copy link
Collaborator

@trezy trezy commented May 27, 2024

Description of change

This is a complete rewrite of @pixi/react. It leverages reflection and type inference to provide a new React pragma, allowing usage of all Pixi.js components via JSX within React applications.

A nice side effect is that this new version should be backward-compatible.

This PR supersedes @Zyie's work on #483, since we're now rewriting the library from the ground up.

Fixes: #476

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)
  • Codemods added

@trezy trezy self-assigned this May 27, 2024
github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

@trezy trezy changed the title @pixi/react v8 [WIP] @pixi/react v8 May 27, 2024
github-actions[bot]

This comment was marked as spam.

github-actions[bot]

This comment was marked as spam.

@Zyie Zyie changed the title [WIP] @pixi/react v8 breaking: [WIP] @pixi/react v8 May 28, 2024
github-actions[bot]

This comment was marked as spam.

@Zyie Zyie changed the title breaking: [WIP] @pixi/react v8 BREAKING CHANGE: [WIP] @pixi/react v8 May 28, 2024
github-actions[bot]

This comment was marked as spam.

@Zyie Zyie changed the title BREAKING CHANGE: [WIP] @pixi/react v8 feat: [WIP] @pixi/react v8 May 28, 2024
@lunarraid
Copy link
Collaborator

What's the reasoning behind a complete rewrite rather than bumping the signatures from the prior version?

@sergioisidoro
Copy link

I'm also curious to know the rational behind a full re-write. The current version already has an implementation of a react reconciler, which seems to work with react fiber, with what looks like a well though out reconciliation strategy and event priorities. Could we perhaps get some more insight behind the factors that you considered?

There is a lot of code that is being removed, and with it a lot of accumulated knowledge and "chesterton fences".

@utenma
Copy link

utenma commented May 31, 2024

maybe?

It leverages reflection and type inference to provide a new React pragma

A nice side effect is that this new version should be backward-compatible.

@lunarraid
Copy link
Collaborator

Definitely not backwards-compatible.

@YVeselovskyi
Copy link

hello :)
is there any info when v8 support will be added?

thanks!

@trezy trezy closed this Jun 15, 2024
@trezy
Copy link
Collaborator Author

trezy commented Jun 15, 2024

I've closed this PR since I've moved development to the dev branch for now. I also created a new issue (#493) to track progress on the new version of the library. That issue also provides context around the decision to rewrite the library from scratch, as well as other changes being made.

@trezy trezy deleted the next-v8 branch July 30, 2024 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: PIXI v8 support
6 participants