Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: major updates to Pixi React site #468

Closed
wants to merge 6 commits into from

Conversation

gregfenton
Copy link

@gregfenton gregfenton commented Jan 9, 2024

Description of change

Quick Start instructions now use Vite (CRA is deprecated) and work without issues (previously was rendering black text on black background). Also modified docusaurus configuration so that use of PIXI.* is no longer needed, following better practices of importing functions as needed.

Pre-Merge Checklist
  • Tests and/or benchmarks are included
  • Documentation is changed or added
  • Lint process passed (npm run lint)
  • Tests passed (npm run test)

Copy link

codesandbox-ci bot commented Jan 9, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1bbd79c:

Sandbox Source
sandbox Configuration

@Zyie
Copy link
Member

Zyie commented Jan 11, 2024

Thanks for this PR @gregfenton, aiming to take a proper look soon but looks good so far!

@Zyie Zyie mentioned this pull request Mar 20, 2024
@Zyie
Copy link
Member

Zyie commented Mar 20, 2024

Hey @gregfenton i've made a new PR #478 thats takes a lot of your work here as i had a few troubles with your branch
but i will make sure to credit you in the release notes for this!

Thank you for putting in the effort to help this project

@Zyie Zyie closed this Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants