#9419: add registry lookup to platform protocol #9421
Conversation
twschiller
added
enhancement
twschiller
changed the title
| @@ -76,9 +74,6 @@ export async function init(): Promise<void> { | |||
| registerBuiltinBricks(); | |||
| registerContribBricks(); | |||
| markDocumentAsFocusableByUser(); | |||
| // Since 1.8.2, the brick registry was de-coupled from the runtime to avoid circular dependencies | |||
| // Since 1.8.10, we inject the platform into the runtime | |||
| initRuntime(brickRegistry); | |||
There was a problem hiding this comment.
Required registry methods are in the platform now
| import { nowTimestamp } from "@/utils/timeUtils"; | ||
| import { flagOn } from "@/auth/featureFlagStorage"; | ||
| import castError from "@/utils/castError"; | ||
|
|
||
| // Introduce a layer of indirection to avoid cyclical dependency between runtime and registry | ||
| // eslint-disable-next-line local-rules/persistBackgroundData -- Static | ||
| let brickRegistry: RegistryProtocol<RegistryId, Brick> = { |
There was a problem hiding this comment.
Available in the platform now
Playwright test results
Details
Flaky testschrome › tests/pageEditor/copyMod.spec.ts › run a copied mod with a built-in integration Skipped testschrome › tests/runtime/googleSheetsIntegration.spec.ts › can activate a google spreadsheet mod with config options |
twschiller
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9421 +/- ##
==========================================
+ Coverage 74.24% 75.64% +1.39%
==========================================
Files 1332 1398 +66
Lines 40817 42311 +1494
Branches 7634 7795 +161
==========================================
+ Hits 30306 32006 +1700
+ Misses 10511 10305 -206 ☔ View full report in Codecov by Sentry. |
What does this PR do?
block->brickon TypedBrickMapDiscussion
Future Work
contentScriptcontext. Some of these should be moved to the main platform protocol, others to the content script platform:pixiebrix-extension/src/bricks/effects/reactivate.ts
Line 20 in a4812c9
For more information on our expectations for the PR process, see the
code review principles doc