fix: release-notes file is updated during acceptance tests

locally it is nice to see the changes but we don't want to accidently break the fixture
pivotal-cf · Aug 10, 2022 · bd71267 · bd71267
1 parent 9b98535
commit bd71267
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 34 deletions.
diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml
@@ -46,6 +46,8 @@ jobs:
           go test --run '(using_kiln|baking_a_tile|generating_release_notes|updating_)' \
             -v --timeout 24h --tags acceptance \
             github.com/pivotal-cf/kiln/internal/acceptance/workflows
+          
+          git reset --hard HEAD
 
       - name: Login to Docker Hub
         uses: docker/login-action@v1

diff --git a/internal/acceptance/workflows/generating_release_notes.feature b/internal/acceptance/workflows/generating_release_notes.feature
@@ -4,6 +4,11 @@ Feature: As a robot, I want to generate release notes
     And GitHub repository "crhntr/hello-release" has release with tag "v0.1.5"
     And the environment variable "GITHUB_TOKEN" is set
 
+    # it does not contain 0.1.4 release header only 0.1.3
+    And "./scenario/fixtures/release_notes.md.erb" has regex matches: id='(?P<version>[\d\.]+)'
+      | version |
+      | 0.1.3   |
+
     When I invoke kiln
       | release-notes                                           |
       | --release-date=2022-07-27                               |

diff --git a/internal/acceptance/workflows/scenario/fixtures/release_notes.md.erb b/internal/acceptance/workflows/scenario/fixtures/release_notes.md.erb
@@ -7,40 +7,6 @@ This topic contains release notes [Hello Tile](https://github.com/crhntr/hello-t
 
 ## <a id='releases'></a> Releases
 
-### <a id='0.1.4'></a> 0.1.4
-
-**Release Date:** 07/27/2022
-
-* **[Bug Fix]** Index page has inconsistent whitespace 
-* Bump hello-release to version `0.1.5`
-
-<table border="1" class="nice">
-  <thead>
-    <tr>
-      <th>Component</th>
-      <th>Version</th>
-      <th>Release Notes</th>
-    </tr>
-  </thead>
-  <tbody>
-    <tr><td>ubuntu-xenial stemcell</td><td>621.0</td><td></td></tr>
-    <tr><td>bpm</td><td>1.1.18</td><td></td></tr>
-    <tr><td>hello-release</td><td>0.1.5</td>
-      <td>
-        <details>
-          <summary>v0.1.5</summary>
-          <pre style="max-width: 30em">
-  **[Fix]**
-  The HTML had  inconsistent	 spacing
-          </pre>
-        </details>
-      </td>
-    </tr>
-  </tbody>
-</table>
-
-
-
 ### <a id='0.1.3'></a> 0.1.3
 
 **Release Date:** 06/26/2022