Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] Remote Wallet Support #68

Open
wants to merge 66 commits into
base: testnet4
Choose a base branch
from

Conversation

humblenginr
Copy link

@humblenginr humblenginr commented Jul 4, 2024

Introduction

This PR introduces support for the Remote Wallet functionality as specified in this spec.

Description

This PR introduces its changes in the remote-wallet directory. There are two architectural components this PR introduces:

  1. WalletRemoteClient - in remote-wallet/client
  2. WalletRemoteServer - in remote-wallet/server

The common package in remote-wallet/common serves as a single source of truth for the communication between the client and server by defining message types and other common things.

The WalletRemoteServer is supposed to be run on the machine where the user's wallet is present. The WalletRemoteClient is a package that is used by the Gocoin node (see here).

This PR adds a new endpoint to the WebUI server for handling the sign_transaction request. The UI is also modified to accommodate the Sign Transaction button.

@humblenginr
Copy link
Author

humblenginr commented Jul 11, 2024

I have added support for realtime connection status update in the UI, and refactored some code, and enhanced error handling.

Screen Recording:

Screen.Recording.2024-07-12.at.3.43.33.AM.mov

In the frontend side, the user experience can be enhanced further by adding support for notifications, loading states, etc.

Todos:

  1. Improve the transaction signing confirmation user experience in the client side
    • Show details of transaction when asking for confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant