-
Notifications
You must be signed in to change notification settings - Fork 226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Remote Wallet Support #68
Open
humblenginr
wants to merge
66
commits into
piotrnar:testnet4
Choose a base branch
from
humblenginr:testnet4
base: testnet4
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I have added support for realtime connection status update in the UI, and refactored some code, and enhanced error handling. Screen Recording: Screen.Recording.2024-07-12.at.3.43.33.AM.movIn the frontend side, the user experience can be enhanced further by adding support for notifications, loading states, etc. Todos:
|
humblenginr
force-pushed
the
testnet4
branch
from
September 2, 2024 11:13
63289a8
to
12a0867
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction
This PR introduces support for the Remote Wallet functionality as specified in this spec.
Description
This PR introduces its changes in the
remote-wallet
directory. There are two architectural components this PR introduces:remote-wallet/client
remote-wallet/server
The common package in
remote-wallet/common
serves as a single source of truth for the communication between the client and server by defining message types and other common things.The WalletRemoteServer is supposed to be run on the machine where the user's wallet is present. The WalletRemoteClient is a package that is used by the Gocoin node (see here).
This PR adds a new endpoint to the WebUI server for handling the
sign_transaction
request. The UI is also modified to accommodate theSign Transaction
button.