Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydrology model #6
base: main
Are you sure you want to change the base?
Hydrology model #6
Changes from 34 commits
b34e753
d0c7e6e
d7e1ede
ffb9ced
f465408
14160a6
091ef16
e27282a
06b316c
9a4dfed
d147afd
1eb4a65
b2b1c69
bb9a728
73c6c03
7e3fb8c
122db4a
6f1bc2c
e00907a
cbcc6a6
cb7f1e2
6df1ee0
a81fb72
f725c31
9ac6746
d1a69a2
99eaa7e
7f72b4e
9499184
6e4b9e8
e50b288
926ff70
862df6a
c972fcf
ec52ee5
a8c146a
ae5c0aa
d48fdf6
1f05aed
3359cfe
1779171
0919a05
3162862
6034755
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we include citations for the model? Also, can we create a sort of table that says why each of the models is interesting? So, here, I guess it's because of potential model misspecification / a potentially complex noise process / numerical error in solving the system.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like this idea, I started making a table which might work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, I tried to install without doing this step but I ran into the following error:
RuntimeError: scikit solver could not be imported
Is scikit.odes required? Or does it just make things faster?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, when exactly did this error appear? Was it when running the notebook? Or did it appear during pip install?
scikit.odes is optional and just makes solving faster. However, if you try to instantiate the model object with the non-default optional argument
solver='scikit'
, it will raise this error if scikits.odes is not available. So if this happened when running the notebook cell which compares the two different solvers, I would consider that the expected behavior.Another option would be to raise a warning and revert to the scipy solver in this case.