Upgrade flake8 to latest (#1498)

.pre-commit-config.yaml

@@ -24,7 +24,7 @@ repos:
                 # - '@trivago/[email protected]' # removing it since pre-commit install fails
 
     - repo: https://github.com/PyCQA/flake8
-      rev: 3.9.2
+      rev: 7.1.1
       hooks:
           - id: flake8
             files: "^querybook/(server|tests)/.*\\.py$"

querybook/server/app/auth/oauth_auth.py

@@ -75,7 +75,7 @@ def oauth_callback(self):
         LOG.debug("Handling Oauth callback...")
 
         if request.args.get("error"):
-            return f"<h1>Error: { Markup.escape(request.args.get('error')) }</h1>"
+            return f"<h1>Error: {Markup.escape(request.args.get('error'))}</h1>"
 
         code = request.args.get("code")
         try:

querybook/server/app/auth/okta_auth.py

@@ -85,7 +85,7 @@ def oauth_callback(self):
         LOG.debug("Handling Oauth callback...")
 
         if request.args.get("error"):
-            return f"<h1>Error: { Markup.escape(request.args.get('error')) }</h1>"
+            return f"<h1>Error: {Markup.escape(request.args.get('error'))}</h1>"
 
         code = request.args.get("code")
         try:

querybook/server/logic/environment.py

@@ -55,7 +55,7 @@ def get_all_visible_environments_by_uid(uid, session=None):
             or_(
                 Environment.hidden != True,  # noqa: E712
                 UserEnvironment.user_id == uid,
-                Environment.public == True,
+                Environment.public == True,  # noqa: E712
             )
         )
         .all()

setup.cfg

@@ -14,6 +14,7 @@ ignore=
     E241,
     E305,
     E402,
+    E721,
     E722,
     E741,
     N801,