Added 'skip-i18n-push' label handling to GithubPRInfoCommand #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geoarion
approved these changes
Aug 18, 2023
garionpin
approved these changes
Aug 18, 2023
aurambaj
approved these changes
Aug 21, 2023
| arity = 1, | ||
| required = false, | ||
| description = "Github label name that is used to trigger skipping i18n push") | ||
| String skipI18NPushLabel = "skip-i18n-push"; |
There was a problem hiding this comment.
Do we plan to customize this?
There was a problem hiding this comment.
I felt having an option to configure the label name to monitor for would be more useful than hard-coding it but for our purposes I still intend on using skip-i18n-push
aurambaj
pushed a commit
that referenced
this pull request
Sep 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the GithubPRInfoCommand to create an environment variable if a specified label is placed on a Github PR. This environment variable can be used in build scripts to early exit before a push occurs to the Mojito backend