Okapi Dependency Update from V. 0.36 to 1.43.0 #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hylstonnb
force-pushed
the
okapi-dependency-update
branch
from
896a436
to
d01b8c8
Compare
hylstonnb
changed the title
hylstonnb
force-pushed
the
okapi-dependency-update
branch
from
d01b8c8
to
b1dc2a5
Compare
hylstonnb
force-pushed
the
okapi-dependency-update
branch
from
71587f8
to
ba4b577
Compare
|
Thank you @hylstonn! this is promising. Would you mind updating the commit message with more detail about each change required? |
aurambaj
reviewed
Aug 28, 2023
| @@ -10,8 +10,8 @@ | |||
| import java.util.regex.Matcher; | |||
| import java.util.regex.Pattern; | |||
| import net.sf.okapi.common.Event; | |||
| import net.sf.okapi.common.annotation.XLIFFNote; | |||
| import net.sf.okapi.common.annotation.XLIFFNoteAnnotation; | |||
| import net.sf.okapi.common.annotation.XLIFFNote; | ||
| import net.sf.okapi.common.annotation.XLIFFNoteAnnotation; | ||
| import net.sf.okapi.common.annotation.Note; | ||
| import net.sf.okapi.common.annotation.NoteAnnotation; |
There was a problem hiding this comment.
is that a new class in addition to XLIFFNoteAnnotation or is replacing it?
There was a problem hiding this comment.
its a replacement, XLIFFNoteAnnotation was deprecated and got removed already.
| maxLength: 18 |
There was a problem hiding this comment.
does the source file contain the extra line? Wondering if it is now keeping it as what's in the source, or if it adds an extra line.
There was a problem hiding this comment.
yes, the source file contains the extra line. Probably a bug they fixed in Okapi
hylstonnb
force-pushed
the
okapi-dependency-update
branch
from
ba4b577
to
5d3ffae
Compare
aurambaj
approved these changes
Aug 29, 2023
…rsion supporting java 8 extractNoteFromXMLComment fix - replaced textUnit.getProperty to textUnitUtils.getNote method getNote fix - return textUnit.getProperty(NoteAnnotation.LOC_NOTE) if the property is not null adding empty line at the end of the yaml files. The source file has the empty line at the end, so okapi version upgrade should have fixed it. XLIFFNoteAnnotation was deprecated and removed. NoteAnnotation class came as a replacement for the old XLIFFNoteAnnotation class. XLIFFNote was deprecated and removed. Note class came as a replacement for the old XLIFFNote class. Property.NOTE string constant was deprecated and removed. It as replaced by NoteAnnotation.LOC_NOTE. The value of the string constant is no longer the same. Property.NOTE value was 'note' and NoteAnnotation.LOC_NOTE value is 'developer'
hylstonnb
force-pushed
the
okapi-dependency-update
branch
from
5d3ffae
to
d302d49
Compare
aurambaj
pushed a commit
that referenced
this pull request
Sep 2, 2023
…rsion supporting java 8 (#12) extractNoteFromXMLComment fix - replaced textUnit.getProperty to textUnitUtils.getNote method getNote fix - return textUnit.getProperty(NoteAnnotation.LOC_NOTE) if the property is not null adding empty line at the end of the yaml files. The source file has the empty line at the end, so okapi version upgrade should have fixed it. XLIFFNoteAnnotation was deprecated and removed. NoteAnnotation class came as a replacement for the old XLIFFNoteAnnotation class. XLIFFNote was deprecated and removed. Note class came as a replacement for the old XLIFFNote class. Property.NOTE string constant was deprecated and removed. It as replaced by NoteAnnotation.LOC_NOTE. The value of the string constant is no longer the same. Property.NOTE value was 'note' and NoteAnnotation.LOC_NOTE value is 'developer'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating Okapi dependency to the latest version which supports java 8. (1.43.0)
Currently the latest version of Okapi is 1.45.0