Introduce 'delta-pull' option to the third party sync command #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maallen
changed the title
maallen
force-pushed
the
smartling_short_circuit
branch
from
5f73f33
to
8f14eb2
Compare
garionpin
reviewed
Aug 11, 2023
webapp/src/main/resources/db/migration/V64__third_party_sync_file_checksum.sql
Outdated
Show resolved
Hide resolved
webapp/src/main/resources/db/migration/V64__third_party_sync_file_checksum.sql
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/entity/ThirdPartyFileChecksum.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/entity/ThirdPartyFileChecksum.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/service/thirdparty/ThirdPartyTMSSmartling.java
Outdated
Show resolved
Hide resolved
aurambaj
reviewed
Aug 11, 2023
webapp/src/main/java/com/box/l10n/mojito/service/thirdparty/ThirdPartyTMSSmartling.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/service/tm/search/TextUnitSearcher.java
Outdated
Show resolved
Hide resolved
maallen
force-pushed
the
smartling_short_circuit
branch
from
24d3587
to
2c4075f
Compare
garionpin
reviewed
Aug 14, 2023
webapp/src/main/java/com/box/l10n/mojito/entity/ThirdPartyFileChecksum.java
Outdated
Show resolved
Hide resolved
garionpin
reviewed
Aug 14, 2023
webapp/src/main/java/com/box/l10n/mojito/service/thirdparty/ThirdPartyTMSSmartling.java
Show resolved
Hide resolved
garionpin
approved these changes
Aug 14, 2023
aurambaj
reviewed
Aug 14, 2023
webapp/src/main/java/com/box/l10n/mojito/entity/ThirdPartyFileChecksum.java
Outdated
Show resolved
Hide resolved
webapp/src/main/java/com/box/l10n/mojito/entity/ThirdPartyFileChecksum.java
Outdated
Show resolved
Hide resolved
webapp/src/main/resources/db/migration/V64__third_party_sync_file_checksum.sql
Outdated
Show resolved
Hide resolved
aurambaj
reviewed
Aug 15, 2023
webapp/src/main/java/com/box/l10n/mojito/entity/ThirdPartyFileChecksum.java
Outdated
Show resolved
Hide resolved
aurambaj
reviewed
Aug 15, 2023
webapp/src/main/java/com/box/l10n/mojito/entity/ThirdPartyFileChecksum.java
Outdated
Show resolved
Hide resolved
…ate to entity, renamed isOrdered method
…lta pull is enabled
maallen
force-pushed
the
smartling_short_circuit
branch
from
5fa74dc
to
57e4919
Compare
aurambaj
pushed a commit
that referenced
this pull request
Sep 2, 2023
Introduce a delta-pull option to the third party sync command, when enabled text unit imports will only occur for batches that contain updates. The implementation stores the checksum of a translated file pulled from a third party provider for a locale, on a subsequent sync compare the checksum of the current file with the stored checksum. If checksums match no changes have occurred and we will exit processing early for that locale.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a
delta-pulloption to the third party sync command, when enabled text unit imports will only occur for batches that contain updates. The implementation stores the checksum of a translated file pulled from a third party provider for a locale, on a subsequent sync compare the checksum of the current file with the stored checksum.If checksums match no changes have occurred and we will exit processing early for that locale.