Documentation and renamed variable

pinterest · Oct 25, 2024 · f7dbb90 · f7dbb90
1 parent 0ff342e
commit f7dbb90
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/webapp/src/main/java/com/box/l10n/mojito/entity/TMTextUnitVariant.java b/webapp/src/main/java/com/box/l10n/mojito/entity/TMTextUnitVariant.java
@@ -69,8 +69,13 @@ public enum Status {
      */
     REVIEW_NEEDED,
 
+    /** Indicates that the text unit has been machine translated in Mojito automatically. */
     MT_TRANSLATED,
 
+    /**
+     * Indicates that the text unit has been machine translated in Mojito automatically and has been
+     * sent for third party review.
+     */
     MT_REVIEW_NEEDED,
     /** A string that doesn't need any work to be performed on it. */
     APPROVED;

diff --git a/webapp/src/main/java/com/box/l10n/mojito/service/tm/search/TextUnitSearcher.java b/webapp/src/main/java/com/box/l10n/mojito/service/tm/search/TextUnitSearcher.java
@@ -179,7 +179,7 @@ NativeCriteria getCriteriaForSearch(TextUnitSearcherParameters searchParameters)
               "tm_text_unit_pending_mt", "tmtupmt", "tmtupmt.tm_text_unit_id", "tu.id"));
     }
 
-    if (searchParameters.isRetrieveUploadedFileUri()) {
+    if (searchParameters.shouldRetrieveUploadedFileUri()) {
       // Retrieve the uploadedFileUri from the ThirdPartyTextUnit table (used when pushing AI
       // translations to third party)
       c.addJoin(
@@ -261,7 +261,7 @@ NativeCriteria getCriteriaForSearch(TextUnitSearcherParameters searchParameters)
             .addProjection("tu.created_date", "tmTextUnitCreatedDate")
             .addProjection("atu.do_not_translate", "doNotTranslate");
 
-    if (searchParameters.isRetrieveUploadedFileUri()) {
+    if (searchParameters.shouldRetrieveUploadedFileUri()) {
       projection.addProjection("tptu.uploaded_file_uri", "uploadedFileUri");
     }
     c.setProjection(projection);

diff --git a/webapp/src/main/java/com/box/l10n/mojito/service/tm/search/TextUnitSearcherParameters.java b/webapp/src/main/java/com/box/l10n/mojito/service/tm/search/TextUnitSearcherParameters.java
@@ -53,7 +53,7 @@ public class TextUnitSearcherParameters {
   String skipAssetPathWithPattern;
   boolean isExcludeUnexpiredPendingMT = false;
   Duration aiTranslationExpiryDuration;
-  boolean isRetrieveUploadedFileUri = false;
+  boolean shouldRetrieveUploadedFileUri = false;
 
   public String getName() {
     return name;
@@ -348,11 +348,11 @@ public void setAiTranslationExpiryDuration(Duration aiTranslationExpiryDuration)
     this.aiTranslationExpiryDuration = aiTranslationExpiryDuration;
   }
 
-  public boolean isRetrieveUploadedFileUri() {
-    return isRetrieveUploadedFileUri;
+  public boolean shouldRetrieveUploadedFileUri() {
+    return shouldRetrieveUploadedFileUri;
   }
 
   public void setIsRetrieveUploadedFileUri(boolean retrieveUploadedFileUri) {
-    this.isRetrieveUploadedFileUri = retrieveUploadedFileUri;
+    this.shouldRetrieveUploadedFileUri = retrieveUploadedFileUri;
   }
 }