UART: Label UARTs, disambiguate Pi4-only, for #428 #431
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an new "supported:" property to overlay pins in order to declare which Pi versions this feature is supported on.
Open
lurch
reviewed
Oct 27, 2021
| direction: output | ||
| active: high | ||
| supported: Pi4 |
There was a problem hiding this comment.
If there was a feature which was only supported on Pi2 and Pi3 (there isn't - I'm just playing devil's advocate), I guess using supported: Pi2 and Pi3 should work okay? (although would obviously look a bit weird in translated versions of the site!)
lurch
reviewed
Oct 27, 2021
| @@ -8,77 +8,91 @@ url: http://elinux.org/RPi_Serial_Connection | |||
| pincount: 18 | |||
| pin: | |||
| '8': | |||
| name: TXD / Transmit | |||
| name: UART0/1 TXD | |||
There was a problem hiding this comment.
Also CTS5 on Pi4 only, just to confuse things further! 🤣
(but AFAIK most people don't use CTS and RTS, so this can probably be safely ignored?)
|
Any reason not to merge this? It would be really helpful when dealing with mutliple UARTs on the Pi4. |
|
This will be made redundant by explicit separation of boards in the rewrite of Pinout - pinout-xyz/pinout-2024#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an new "supported:" property to overlay pins in order to declare which Pi versions this feature is supported on.