Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: use a unique session for checkpoint runner #56487

Merged
merged 1 commit into from
Oct 9, 2024

Conversation

Leavrth
Copy link
Contributor

@Leavrth Leavrth commented Oct 9, 2024

What problem does this PR solve?

Issue Number: close #56488 #56308 #56410 #56450

Problem Summary:
the session cannot be used concurrently.

What changed and how does it work?

use a unique session for checkpoint runner.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed do-not-merge/needs-tests-checked labels Oct 9, 2024
Copy link

tiprow bot commented Oct 9, 2024

Hi @Leavrth. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 68.42105% with 6 lines in your changes missing coverage. Please review.

Project coverage is 76.0725%. Comparing base (df821b9) to head (dec1a0c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #56487        +/-   ##
================================================
+ Coverage   73.2357%   76.0725%   +2.8367%     
================================================
  Files          1626       1626                
  Lines        448692     448878       +186     
================================================
+ Hits         328603     341473     +12870     
+ Misses        99977      86417     -13560     
- Partials      20112      20988       +876     
Flag Coverage Δ
integration 50.4153% <68.4210%> (?)
unit 72.4566% <31.5789%> (+0.0165%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9478% <ø> (ø)
parser ∅ <ø> (∅)
br 63.0512% <68.4210%> (+17.5797%) ⬆️

@Leavrth
Copy link
Contributor Author

Leavrth commented Oct 9, 2024

/retest

Copy link

tiprow bot commented Oct 9, 2024

@Leavrth: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2024
@Tristan1900
Copy link
Contributor

it might also solve this flaky test based on the issue it solves? #56450

Copy link

ti-chi-bot bot commented Oct 9, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: 3pointer, BornChanger

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Oct 9, 2024
Copy link

ti-chi-bot bot commented Oct 9, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-10-09 02:33:57.054675799 +0000 UTC m=+1013392.474888796: ☑️ agreed by 3pointer.
  • 2024-10-09 03:37:32.933914321 +0000 UTC m=+1017208.354127330: ☑️ agreed by BornChanger.

@ti-chi-bot ti-chi-bot bot merged commit 6e84244 into pingcap:master Oct 9, 2024
35 of 52 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

br restore failed
4 participants