-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ddl: args v2 for add/drop/rename index, include PK/vector-index #56130
Merged
Merged
Changes from all commits
Commits
Show all changes
39 commits
Select commit
Hold shift + click to select a range
5cc608a
Add args for add/drop index/primary key
joechenrh 8518713
Update
joechenrh 265db55
Update code
joechenrh ea07abe
Update code
joechenrh b475261
Fix test
joechenrh bc0b14f
Merge branch 'master' into addargs-indexes
joechenrh 2a28718
Fix bazel and add tests
joechenrh 3ffe864
Fix test
joechenrh c97dd4e
Update decode for v1
joechenrh 9ca24d4
Merge branch 'master' into addargs-indexes
joechenrh bd046aa
Fix test
joechenrh dc1642c
Add some comments
joechenrh cdd9d74
Some refactor
joechenrh 69fffec
Add argument for rename index
joechenrh a649d2d
Merge branch 'master' into addargs-indexes
joechenrh 3134c5d
Merge vector index
joechenrh 024e2bd
Update
joechenrh 240aea6
Update
joechenrh 2cacf44
Update
joechenrh 3962b53
Add tests for vector index args
joechenrh 1e657b8
Change version of subjobs
joechenrh e559cb8
Fix bdr bug
joechenrh 38c092c
Fix bdr bug
joechenrh 871bbb3
Fix mysql test
joechenrh fffe244
Merge branch 'master' into addargs-indexes
joechenrh a0fec13
Fix after merge
joechenrh b6bfc48
Fix build
joechenrh 124143a
Address comments
joechenrh dcc8a59
Fix
joechenrh 436bcf5
Add more comments
joechenrh d9711a8
Address comments
joechenrh f8e70e6
Fix bug
joechenrh 7b2bb76
Address comment
joechenrh 6ad4cfd
Remove IsFinishedArg flag
joechenrh 92df5ab
Address comments
joechenrh cff4182
Merge three args into one
joechenrh e1177cf
Fix build
joechenrh fd08cef
Update argument encoding and decoding.
joechenrh d870599
Address comments
joechenrh File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The first decode is useless, since the first two elements are slice after #47135.
So in the new logic, we only decode them using slice.