Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: re-structure job scheduler and ddl executor, part 1 #54967

Merged
merged 1 commit into from
Jul 29, 2024

Conversation

D3Hunter
Copy link
Contributor

@D3Hunter D3Hunter commented Jul 26, 2024

What problem does this PR solve?

Issue Number: ref #54436

Problem Summary:

What changed and how does it work?

move code belongs to one type receiver to one file

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test, this PR is large, but we only move code, no logic change

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 26, 2024
Copy link

tiprow bot commented Jul 26, 2024

Hi @D3Hunter. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@D3Hunter D3Hunter changed the title ddl: re-structure job scheduler and ddl executor ddl: re-structure job scheduler and ddl executor, part 1 Jul 26, 2024
@D3Hunter D3Hunter requested a review from lance6716 July 26, 2024 10:54
@D3Hunter D3Hunter mentioned this pull request Jul 26, 2024
54 tasks
Copy link

codecov bot commented Jul 26, 2024

Codecov Report

Attention: Patch coverage is 70.72243% with 231 lines in your changes missing coverage. Please review.

Project coverage is 74.6184%. Comparing base (da7d83f) to head (27e2960).
Report is 8 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #54967        +/-   ##
================================================
- Coverage   74.6935%   74.6184%   -0.0751%     
================================================
  Files          1559       1562         +3     
  Lines        363875     440947     +77072     
================================================
+ Hits         271791     329028     +57237     
- Misses        72375      91634     +19259     
- Partials      19709      20285       +576     
Flag Coverage Δ
integration 49.5754% <55.0063%> (?)
unit 71.6393% <69.2015%> (-1.9441%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 52.9567% <ø> (-2.2327%) ⬇️
parser ∅ <ø> (∅)
br 52.5422% <ø> (+4.8441%) ⬆️

@ti-chi-bot ti-chi-bot bot added the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Jul 28, 2024
Copy link

ti-chi-bot bot commented Jul 29, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716, tangenta

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Jul 29, 2024
Copy link

ti-chi-bot bot commented Jul 29, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-07-28 13:23:13.751825661 +0000 UTC m=+102910.031873729: ☑️ agreed by lance6716.
  • 2024-07-29 03:01:10.12511328 +0000 UTC m=+151986.405161349: ☑️ agreed by tangenta.

@ti-chi-bot ti-chi-bot bot merged commit 7ffc7c9 into pingcap:master Jul 29, 2024
23 checks passed
@D3Hunter D3Hunter deleted the move-job-scheduler branch July 29, 2024 03:57
hawkingrei pushed a commit to hawkingrei/tidb that referenced this pull request Aug 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants