Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: check kill signal against 0 (#50029) #50168

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #50029

What problem does this PR solve?

Issue Number: ref #49643

Problem Summary:

Previously the kill signal was checked against 1, however TiDB uses non-zero values to indicate a kill signal.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • Simple enough change.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR. labels Jan 8, 2024
@ti-chi-bot ti-chi-bot mentioned this pull request Jan 8, 2024
12 tasks
@ti-chi-bot ti-chi-bot bot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 8, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 26, 2024
@ti-chi-bot ti-chi-bot removed the cherry-pick-approved Cherry pick PR approved by release team. label Feb 27, 2024
@ti-chi-bot ti-chi-bot closed this Feb 27, 2024
@ti-chi-bot ti-chi-bot added the cherry-pick-approved Cherry pick PR approved by release team. label Feb 27, 2024
@ekexium ekexium reopened this Feb 27, 2024
Signed-off-by: ekexium <[email protected]>
@ti-chi-bot ti-chi-bot bot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Feb 27, 2024
@ti-chi-bot ti-chi-bot bot added the lgtm label Feb 28, 2024
Copy link

ti-chi-bot bot commented Feb 28, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cfzjywxk, zyguan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot removed the needs-1-more-lgtm Indicates a PR needs 1 more LGTM. label Feb 28, 2024
Copy link

ti-chi-bot bot commented Feb 28, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-02-28 01:43:42.830357615 +0000 UTC m=+1012711.577980748: ☑️ agreed by cfzjywxk.
  • 2024-02-28 02:37:08.8858977 +0000 UTC m=+1015917.633520811: ☑️ agreed by zyguan.

@ekexium
Copy link
Contributor

ekexium commented Feb 28, 2024

/retest

@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 28, 2024
@ekexium
Copy link
Contributor

ekexium commented Feb 28, 2024

/retest

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

❗ No coverage uploaded for pull request base (release-7.1@f942e74). Click here to learn what that means.
The diff coverage is 52.3809%.

Additional details and impacted files
@@               Coverage Diff                @@
##             release-7.1     #50168   +/-   ##
================================================
  Coverage               ?   73.3649%           
================================================
  Files                  ?       1211           
  Lines                  ?     380408           
  Branches               ?          0           
================================================
  Hits                   ?     279086           
  Misses                 ?      83519           
  Partials               ?      17803           

@ti-chi-bot ti-chi-bot bot merged commit 8018155 into pingcap:release-7.1 Feb 28, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved cherry-pick-approved Cherry pick PR approved by release team. lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/cherry-pick-for-release-7.1 This PR is cherry-picked to release-7.1 from a source PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants