planner: remove old useless unfinished index advisor implementation (#…

…55810) ref #12303
pingcap · Sep 4, 2024 · 2bd5660 · 2bd5660
1 parent 649dce7
commit 2bd5660
Show file tree

Hide file tree

Showing 14 changed files with 7,527 additions and 8,141 deletions.
diff --git a/pkg/executor/BUILD.bazel b/pkg/executor/BUILD.bazel
@@ -36,7 +36,6 @@ go_library(
         "foreign_key.go",
         "grant.go",
         "import_into.go",
-        "index_advise.go",
         "index_merge_reader.go",
         "infoschema_reader.go",
         "insert.go",
@@ -330,7 +329,6 @@ go_test(
         "historical_stats_test.go",
         "hot_regions_history_table_test.go",
         "import_into_test.go",
-        "index_advise_test.go",
         "infoschema_cluster_table_test.go",
         "infoschema_reader_internal_test.go",
         "infoschema_reader_test.go",

diff --git a/pkg/executor/builder.go b/pkg/executor/builder.go
@@ -209,8 +209,6 @@ func (b *executorBuilder) build(p base.Plan) exec.Executor {
 		return b.buildLockStats(v)
 	case *plannercore.UnlockStats:
 		return b.buildUnlockStats(v)
-	case *plannercore.IndexAdvise:
-		return b.buildIndexAdvise(v)
 	case *plannercore.PlanReplayer:
 		return b.buildPlanReplayer(v)
 	case *plannercore.PhysicalLimit:
@@ -1089,21 +1087,6 @@ func (b *executorBuilder) buildUnlockStats(v *plannercore.UnlockStats) exec.Exec
 	return e
 }
 
-func (b *executorBuilder) buildIndexAdvise(v *plannercore.IndexAdvise) exec.Executor {
-	e := &IndexAdviseExec{
-		BaseExecutor: exec.NewBaseExecutor(b.ctx, nil, v.ID()),
-		IsLocal:      v.IsLocal,
-		indexAdviseInfo: &IndexAdviseInfo{
-			Path:           v.Path,
-			MaxMinutes:     v.MaxMinutes,
-			MaxIndexNum:    v.MaxIndexNum,
-			LineFieldsInfo: v.LineFieldsInfo,
-			Ctx:            b.ctx,
-		},
-	}
-	return e
-}
-
 func (b *executorBuilder) buildPlanReplayer(v *plannercore.PlanReplayer) exec.Executor {
 	if v.Load {
 		e := &PlanReplayerLoadExec{

diff --git a/pkg/executor/index_advise.go b/pkg/executor/index_advise.go
diff --git a/pkg/executor/index_advise_test.go b/pkg/executor/index_advise_test.go
diff --git a/pkg/parser/ast/BUILD.bazel b/pkg/parser/ast/BUILD.bazel
@@ -3,7 +3,6 @@ load("@io_bazel_rules_go//go:def.bzl", "go_library", "go_test")
 go_library(
     name = "ast",
     srcs = [
-        "advisor.go",
         "ast.go",
         "base.go",
         "ddl.go",

diff --git a/pkg/parser/ast/advisor.go b/pkg/parser/ast/advisor.go
diff --git a/pkg/parser/ast/ast.go b/pkg/parser/ast/ast.go
@@ -248,8 +248,6 @@ func GetStmtLabel(stmtNode StmtNode) string {
 		return "Use"
 	case *CreateBindingStmt:
 		return "CreateBinding"
-	case *IndexAdviseStmt:
-		return "IndexAdvise"
 	case *DropBindingStmt:
 		return "DropBinding"
 	case *TraceStmt: