fix(frontend): prevent hiding post verification settings

pingcap · Sep 9, 2024 · ba36a21 · ba36a21
1 parent 8f194d3
commit ba36a21
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 12 deletions.
diff --git a/frontend/app/src/app/(main)/(admin)/site-settings/integrations/page.tsx b/frontend/app/src/app/(main)/(admin)/site-settings/integrations/page.tsx
@@ -6,7 +6,7 @@ export default async function LangfuseSettingsPage () {
 
   return (
     <>
-      <IntegrationsSettings schema={settings} />
+      <IntegrationsSettings schema={settings} showPostVerificationSettings={!!process.env.EXPERIMENTAL_MESSAGE_VERIFY_SERVICE} />
     </>
   );
 }

diff --git a/frontend/app/src/components/settings/IntegrationsSettings.tsx b/frontend/app/src/components/settings/IntegrationsSettings.tsx
@@ -2,14 +2,12 @@
 
 import type { AllSettings } from '@/api/site-settings';
 import { SettingsField } from '@/components/settings/SettingsField';
-import { useExperimentalFeatures } from '@/experimental/experimental-features-provider';
-
-export function IntegrationsSettings ({ schema }: { schema: AllSettings }) {
 
+export function IntegrationsSettings ({ schema, showPostVerificationSettings }: { schema: AllSettings, showPostVerificationSettings: boolean }) {
   return (
     <div className="space-y-8 max-w-screen-md">
       <LangfuseSettings schema={schema} />
-      <ExperimentalPostVerificationSettings schema={schema} />
+      {showPostVerificationSettings && <ExperimentalPostVerificationSettings schema={schema} />}
     </div>
   );
 }
@@ -26,12 +24,6 @@ export function LangfuseSettings ({ schema, hideTitle, disabled, onChanged }: {
 }
 
 export function ExperimentalPostVerificationSettings ({ schema, hideTitle, disabled, onChanged }: { schema: AllSettings, hideTitle?: boolean, disabled?: boolean, onChanged?: () => void }) {
-  const { message_verify_service } = useExperimentalFeatures();
-
-  if (!message_verify_service) {
-    return null;
-  }
-
   return (
     <section className="space-y-6">
       {!hideTitle && <h2 className="text-lg font-medium">[Experimental] Post verifications</h2>}

diff --git a/frontend/app/src/components/settings/SettingsField.tsx b/frontend/app/src/components/settings/SettingsField.tsx
@@ -115,7 +115,7 @@ export function SettingsField ({ name, item, arrayItemSchema, objectSchema, onCh
           el = <Input {...props} placeholder={item.default} />;
           break;
         case 'bool':
-          el = <Switch {...props} onChange={undefined} checked={props.value} onCheckedChange={props.onChange} />;
+          el = <Switch className='block' {...props} onChange={undefined} checked={props.value} onCheckedChange={props.onChange} />;
           break;
         case 'dict':
         case 'list':