fix(frontend): prevent json editor setting undefined value

pingcap · Aug 6, 2024 · 1f2ddb0 · 1f2ddb0
1 parent fc75861
commit 1f2ddb0
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/frontend/app/src/components/embedding-model/CreateEmbeddingModelForm.tsx b/frontend/app/src/components/embedding-model/CreateEmbeddingModelForm.tsx
@@ -66,6 +66,7 @@ export function CreateEmbeddingModelForm ({ transitioning, onCreated }: { transi
         ...form.getValues(),
         model: provider.default_embedding_model,
         credentials: provider.credentials_type === 'dict' ? undefined : '',
+        config: '{}'
       });
     } else {
       const { name } = form.getValues();
@@ -74,6 +75,7 @@ export function CreateEmbeddingModelForm ({ transitioning, onCreated }: { transi
         provider: '',
         credentials: '',
         model: '',
+        config: '{}'
       });
     }
   }, [provider]);

diff --git a/frontend/app/src/components/form/widgets/CodeInput.tsx b/frontend/app/src/components/form/widgets/CodeInput.tsx
@@ -94,8 +94,9 @@ export const CodeInput = forwardRef<any, CodeInputProps>(({
 
   useEffect(() => {
     if (editor) {
-      if (value !== editor.getValue()) {
-        editor.setValue(value);
+      const rValue = value || '';
+      if (rValue !== editor.getValue()) {
+        editor.setValue(rValue);
       }
     }
   }, [editor, value]);

diff --git a/frontend/app/src/components/graph/components/JsonEditor.tsx b/frontend/app/src/components/graph/components/JsonEditor.tsx
@@ -40,7 +40,9 @@ export const JsonEditor = forwardRef<monaco.editor.IStandaloneCodeEditor | undef
 
   useEffect(() => {
     if (editor) {
-      editor.setValue(defaultValue);
+      if (defaultValue != null) {
+        editor.setValue(defaultValue);
+      }
     }
   }, [editor, defaultValue]);