Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

br: modify to use one kubeconfig for multiple data planes (#5186) #5209

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5186

What problem does this PR solve?

Modify to use one kubeconfig for multiple data planes

Closes #5183

What is changed and how does it work?

Change the flag federation-kubeconfig-path to the kubeconfig file path. Then read the kubeconfig file and use the contexts in kubeconfig file mapping to the data planes

After this change, the secret that stores the kubeconfig file should be configured like this:

apiVersion: v1
kind: Secret
metadata:
  name: br-federation-kubeconfig
type: Opaque
data:
  kubeconfig: {encoded-kubeconfig}

If the user want to use custom secret name or custom data key, he should change the value of chart .brFederationManager.federationKubeconfigSecret or .brFederationManager.federationKubeconfigSecretKey

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@codecov-commenter
Copy link

codecov-commenter commented Jul 28, 2023

Codecov Report

Merging #5209 (9832290) into release-1.5 (d775285) will increase coverage by 0.00%.
The diff coverage is 0.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #5209   +/-   ##
============================================
  Coverage        57.93%   57.94%           
============================================
  Files              248      248           
  Lines            29343    29343           
============================================
+ Hits             17001    17003    +2     
+ Misses           10693    10692    -1     
+ Partials          1649     1648    -1     
Flag Coverage Δ
unittest 57.94% <0.00%> (+<0.01%) ⬆️

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from wangle1321. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@csuzhangxc csuzhangxc merged commit 2021292 into pingcap:release-1.5 Jul 28, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants