Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DNM] Combined prs #5208

Closed
wants to merge 13 commits into from
Closed

[DNM] Combined prs #5208

wants to merge 13 commits into from

Conversation

BornChanger
Copy link
Contributor

What problem does this PR solve?

What is changed and how does it work?

Combined PRs of
5186
5207
5199
5188

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

BornChanger and others added 10 commits July 27, 2023 23:49
@BornChanger
ebs br: make snapshot size calculation optional
f9dfef4 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: enable by default
4303007 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: convert the control from a switch to a level
56ddcdd 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: use literal level value
78d9c5e 
Signed-off-by: BornChanger <[email protected]>
@WangLe1321 @BornChanger
br: modify to use one kubeconfig for multiple data planes
8da959c 
Signed-off-by: WangLe1321 <[email protected]>
@WangLe1321 @BornChanger
br: add comments to values.yaml
d7a7ae3 
Signed-off-by: WangLe1321 <[email protected]>
@WangLe1321 @BornChanger
br: backup manifests related to tidb cluster in EBS backup
48e7d3d 
Signed-off-by: WangLe1321 <[email protected]>
@BornChanger
ebs br: fail delete cr operation if backup meta is missing
6135e44 
Signed-off-by: BornChanger <[email protected]>
@WangLe1321 @BornChanger
br: add incremental backup size for volume snapshot backup
4e56b15 
Signed-off-by: WangLe1321 <[email protected]>
@BornChanger
*: manual cp
33580d9 
Signed-off-by: BornChanger <[email protected]>
@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge July 27, 2023 15:50
@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 27, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the size/XXL label Jul 27, 2023
@BornChanger
*: code format
c2ac3c5 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: code format
44eefb2 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
*: fix typo
f91a7b4 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
Copy link
Contributor Author

/retest

@codecov-commenter
Copy link

codecov-commenter commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #5208 (f91a7b4) into master (f838c88) will decrease coverage by 9.46%.
Report is 2 commits behind head on master.
The diff coverage is 8.51%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5208      +/-   ##
==========================================
- Coverage   57.98%   48.52%   -9.46%     
==========================================
  Files         245      209      -36     
  Lines       29240    27820    -1420     
==========================================
- Hits        16954    13501    -3453     
- Misses      10639    12688    +2049     
+ Partials     1647     1631      -16
Flag Coverage Δ
e2e 48.52% <8.51%> (?)
unittest ?

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-br

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: The label(s) /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 28, 2023

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger BornChanger closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@shonge shonge Awaiting requested review from shonge

Assignees
No one assigned
Labels
needs-rebase size/XXL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BornChanger @codecov-commenter @WangLe1321