Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

br: GC by MaxReservedTime works on completed or failed backups #5148

Merged
merged 4 commits into from
Jul 6, 2023
Merged

br: GC by MaxReservedTime works on completed or failed backups #5148

merged 4 commits into from
Jul 6, 2023

Conversation

BornChanger
Copy link
Contributor

@BornChanger BornChanger commented Jul 5, 2023 •
edited
Loading

What problem does this PR solve?

Close #5147 #4992 #5129

What is changed and how does it work?

This PR addresses 3 problems

  1. Make sure backup schedule will GC completed and failed backups when they are expired.
  2. Precheck tikv replicas in restore tc with the backup metadata for EBS restore
  3. Make sure recovery mode is on when doing EBS across k8s restore

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from bornchanger. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot requested review from lichunzhu and shonge July 5, 2023 07:19
@ti-chi-bot ti-chi-bot bot added the size/XS label Jul 5, 2023
@BornChanger
Copy link
Contributor Author

/cc @WangLe1321 @csuzhangxc

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@BornChanger: The label(s) /@wangle1321, /@csuzhangxc cannot be applied, because the repository doesn't have them.

In response to this:

/cc @WangLe1321 @csuzhangxc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot bot added size/S and removed size/XS labels Jul 5, 2023
@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ti-chi-bot ti-chi-bot bot added size/XL and removed size/S labels Jul 5, 2023
@BornChanger
pkg: make lint happy
c003c1f 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
Copy link
Contributor Author

/retest

@BornChanger
*: simplify cases
29a0a66 
Signed-off-by: BornChanger <[email protected]>
@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov-commenter
Copy link

codecov-commenter commented Jul 5, 2023 •
edited
Loading

Codecov Report

Merging #5148 (29a0a66) into master (ae97a57) will increase coverage by 4.95%.
The diff coverage is 88.88%.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #5148      +/-   ##
==========================================
+ Coverage   57.69%   62.65%   +4.95%     
==========================================
  Files         248      252       +4     
  Lines       28957    32546    +3589     
==========================================
+ Hits        16708    20391    +3683     
+ Misses      10615    10417     -198     
- Partials     1634     1738     +104
Flag Coverage Δ
e2e 38.08% <0.00%> (?)
unittest 57.98% <92.30%> (+0.28%) ⬆️

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-serial

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 5, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind-across-kubernetes

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@BornChanger: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@BornChanger
Copy link
Contributor Author

/test pull-e2e-kind

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@csuzhangxc csuzhangxc merged commit 3279ab5 into pingcap:master Jul 6, 2023
@BornChanger
Copy link
Contributor Author

/cherry-pick release-1.5

@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jul 6, 2023

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@ti-chi-bot ti-chi-bot mentioned this pull request Jul 6, 2023
Merged
10 tasks
@ti-chi-bot
Copy link
Member

@BornChanger: new pull request created to branch release-1.5: #5152.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

csuzhangxc pushed a commit that referenced this pull request Jul 7, 2023
@ti-chi-bot @BornChanger
br: GC by MaxReservedTime works on completed or failed backups (#5148) (
f32afd6 
#5152)

Signed-off-by: BornChanger <[email protected]>
Co-authored-by: BornChanger <[email protected]>
Rustin170506 added a commit to Rustin170506/tidb-operator that referenced this pull request Jul 28, 2023
@Rustin170506
ticdc: upgrade ticdc first if version >= v5.1.0
fede680 
Signed-off-by: hi-rustin <[email protected]>

ticdc: add tests

Signed-off-by: hi-rustin <[email protected]>

ticdc: add more tests

Signed-off-by: hi-rustin <[email protected]>

ticdc: rename

Signed-off-by: hi-rustin <[email protected]>

ticdc: add deps ro controller

Signed-off-by: hi-rustin <[email protected]>

ticdc: use correct version

Signed-off-by: hi-rustin <[email protected]>

ticdc: add test for GetImageVersion

Signed-off-by: hi-rustin <[email protected]>

br: GC by MaxReservedTime works on completed or failed backups (pingcap#5148)
Rustin170506 added a commit to Rustin170506/tidb-operator that referenced this pull request Jul 28, 2023
@Rustin170506
ticdc: upgrade ticdc first if version >= v5.1.0
7f46ef8 
Signed-off-by: hi-rustin <[email protected]>

ticdc: add tests

Signed-off-by: hi-rustin <[email protected]>

ticdc: add more tests

Signed-off-by: hi-rustin <[email protected]>

ticdc: rename

Signed-off-by: hi-rustin <[email protected]>

ticdc: add deps ro controller

Signed-off-by: hi-rustin <[email protected]>

ticdc: use correct version

Signed-off-by: hi-rustin <[email protected]>

ticdc: add test for GetImageVersion

Signed-off-by: hi-rustin <[email protected]>

br: GC by MaxReservedTime works on completed or failed backups (pingcap#5148)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@shonge shonge Awaiting requested review from shonge

@csuzhangxc csuzhangxc Awaiting requested review from csuzhangxc

@WangLe1321 WangLe1321 Awaiting requested review from WangLe1321

Assignees
No one assigned
Labels
area/ebs-br size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

br: gc by MaxReservedTime doesn't work for scheduled backup
4 participants
@BornChanger @codecov-commenter @ti-chi-bot @csuzhangxc