opt: do not evict leader when changing PVC size (#5101)

[ti-chi-bot]

This is an automated cherry-pick of #5101

What problem does this PR solve?

Do not evict leader when changing (increasing) PVC size, as if the storage size is not enough, the leader eviction will be blocked (never finished)

NOTE: if changing size and rolling restart TiKV at the same time, leader eviction is still triggered.

What is changed and how does it work?

Code changes

• Has Go code change
• Has CI related scripts change

Tests

• Unit test
• E2E test
• Manual test
  • only change storage size, no evict leader happen
  • only change IOPS/throughput, evict leader takes effect
  • change both IOPS/throughput&storage size, no evict leader happen
• No code

Side effects

• Breaking backward compatibility
• Other side effects:

Related changes

• Need to cherry-pick to the release branch
• Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Skip evicting leader for TiKV when changing PVC size

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kanshiori for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[csuzhangxc]

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

[ti-chi-bot]

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[codecov-commenter]

Codecov Report

Merging #5107 (53856fa) into release-1.5 (fc03647) will increase coverage by 8.69%.
The diff coverage is 7.40%.

Additional details and impacted files

@@               Coverage Diff               @@
##           release-1.5    #5107      +/-   ##
===============================================
+ Coverage        59.02%   67.72%   +8.69%     
===============================================
  Files              228      232       +4     
  Lines            26516    29762    +3246     
===============================================
+ Hits             15651    20156    +4505     
+ Misses            9329     8034    -1295     
- Partials          1536     1572      +36     

Flag	Coverage Δ
e2e	52.48% <7.40%> (?)
unittest	59.00% <8.00%> (-0.03%)	⬇️

[csuzhangxc]

/test pull-e2e-kind
/test pull-e2e-kind-tngm

[ti-chi-bot]

@csuzhangxc: The label(s) /pull-e2e-kind, /pull-e2e-kind-tngm cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind
/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csuzhangxc]

/test pull-e2e-kind-tngm

[ti-chi-bot]

@csuzhangxc: The label(s) /pull-e2e-kind-tngm cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-tngm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csuzhangxc]

/test pull-e2e-kind-basic
/test pull-e2e-kind-br

[ti-chi-bot]

@csuzhangxc: The label(s) /pull-e2e-kind-basic, /pull-e2e-kind-br cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-basic
/test pull-e2e-kind-br

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csuzhangxc]

/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously

[ti-chi-bot]

@csuzhangxc: The label(s) /pull-e2e-kind-serial, /pull-e2e-kind-tikv-scale-simultaneously cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-serial
/test pull-e2e-kind-tikv-scale-simultaneously

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[csuzhangxc]

/test pull-e2e-kind-serial

[ti-chi-bot]

@csuzhangxc: The label(s) /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[ti-chi-bot]

@csuzhangxc: No presubmit jobs available for pingcap/[email protected]

In response to this:

/test pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.