pkg: add 2 operator related tags to restored ebs volume #5104

BornChanger · 2023-06-28T13:07:46Z

What problem does this PR solve?

What is changed and how does it work?

Add 2 more tags for the restored aws ebs volume, like
'CSIVolumeName=<pvc_name> ex: pvc-daff-ddfasdfs-dafdsaf-dafsdf-asdfa
kubernetes.io/created-for/pvc/name=<tikv_pod_name> Ex: tikv-mussel-prod-tikv-10'

Code changes

Has Go code change
Has CI related scripts change

Tests

Unit test
E2E test
Manual test
No code

Side effects

Breaking backward compatibility
Other side effects:

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

Signed-off-by: BornChanger <[email protected]>

BornChanger · 2023-06-28T13:08:10Z

/cc @WangLe1321 @csuzhangxc

ti-chi-bot · 2023-06-28T13:08:13Z

@BornChanger: The label(s) /@wangle1321, /@csuzhangxc cannot be applied, because the repository doesn't have them.

In response to this:

/cc @WangLe1321 @csuzhangxc

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

codecov-commenter · 2023-06-28T13:48:57Z

Codecov Report

Merging #5104 (4b3e9e0) into master (afecdc7) will increase coverage by 7.65%.
The diff coverage is 15.85%.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5104      +/-   ##
==========================================
+ Coverage   57.77%   65.43%   +7.65%     
==========================================
  Files         248      252       +4     
  Lines       28886    32344    +3458     
==========================================
+ Hits        16689    21164    +4475     
+ Misses      10569     9515    -1054     
- Partials     1628     1665      +37

Flag	Coverage Δ
e2e	`48.18% <0.00%> (?)`
unittest	`57.69% <17.33%> (-0.08%)`	⬇️

Signed-off-by: BornChanger <[email protected]>

BornChanger · 2023-06-29T06:23:52Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-06-29T06:23:54Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-06-29T06:23:54Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: BornChanger <[email protected]>

pkg/backup/snapshotter/snapshotter_aws.go

pkg/backup/util/aws_ebs.go

Signed-off-by: BornChanger <[email protected]>

BornChanger · 2023-06-29T07:19:33Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-06-29T07:19:34Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-29T07:19:35Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-29T09:13:24Z

/test pull-e2e-kind

ti-chi-bot · 2023-06-29T09:13:26Z

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-29T09:13:26Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-30T10:21:07Z

/merge

ti-chi-bot · 2023-06-30T10:21:09Z

@BornChanger: We have migrated to builtin LGTM and approve plugins for reviewing.

Please use /approve when you want approve this pull request.

The changes announcement: LGTM plugin changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

BornChanger · 2023-06-30T10:22:10Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-06-30T10:22:12Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-30T10:22:12Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-06-30T10:24:39Z

[LGTM Timeline notifier]

Timeline:

2023-06-29 14:27:09.178748705 +0000 UTC m=+9312.553326555: ☑️ agreed by csuzhangxc.
2023-06-29 14:36:53.600487898 +0000 UTC m=+9896.975065734: ✖️🔁 reset by ti-chi-bot[bot].
2023-06-30 10:19:55.302776385 +0000 UTC m=+80878.677354236: ☑️ agreed by WangLe1321.
2023-06-30 10:24:38.622245361 +0000 UTC m=+81161.996823212: ✖️🔁 reset by ti-chi-bot[bot].

ti-chi-bot · 2023-06-30T10:24:40Z

New changes are detected. LGTM label has been removed.

BornChanger · 2023-06-30T11:01:55Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-06-30T11:01:57Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-30T11:01:58Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-30T14:30:20Z

/test pull-e2e-kind pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-06-30T14:30:22Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-serial, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-30T14:30:23Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-30T15:08:12Z

/test pull-e2e-kind pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-06-30T15:08:14Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-serial, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-30T15:08:15Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-serial pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-30T16:32:07Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-06-30T16:32:08Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-30T16:32:09Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-07-04T06:48:45Z

/cherry-pick release-1.5

ti-chi-bot · 2023-07-04T06:48:47Z

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-04T06:49:21Z

@BornChanger: new pull request created to branch release-1.5: #5139.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: BornChanger <[email protected]> Co-authored-by: BornChanger <[email protected]>

pkg: add 2 operator related tags to restored ebs volume

1bb611f

Signed-off-by: BornChanger <[email protected]>

ti-chi-bot bot requested review from howardlau1999 and shonge June 28, 2023 13:07

ti-chi-bot bot added the size/L label Jun 28, 2023

ti-chi-bot bot requested review from csuzhangxc and WangLe1321 June 28, 2023 13:08

BornChanger removed request for howardlau1999 and shonge June 28, 2023 13:08

BornChanger mentioned this pull request Jun 28, 2023

EBS BR support to multiple k8s cluster TiDB #5003

Open

*: make compiler happy

2900fb9

Signed-off-by: BornChanger <[email protected]>

BornChanger force-pushed the new_volume_tags branch from 5284578 to 2900fb9 Compare June 28, 2023 13:58

*: amend code

4da5228

Signed-off-by: BornChanger <[email protected]>

BornChanger force-pushed the new_volume_tags branch from c52792d to 4da5228 Compare June 29, 2023 05:49

*: polish failure reason

49ceb26

Signed-off-by: BornChanger <[email protected]>

csuzhangxc reviewed Jun 29, 2023

View reviewed changes

pkg/backup/snapshotter/snapshotter_aws.go Outdated Show resolved Hide resolved

pkg/backup/util/aws_ebs.go Outdated Show resolved Hide resolved

*: address comments

ba04fd8

Signed-off-by: BornChanger <[email protected]>

BornChanger requested a review from csuzhangxc June 29, 2023 07:08

BornChanger added the type/cherry-pick-for-release-1.5 label Jun 29, 2023

ti-chi-bot bot added the lgtm label Jun 30, 2023

Merge branch 'master' into new_volume_tags

4b3e9e0

ti-chi-bot bot removed the lgtm label Jun 30, 2023

BornChanger added the lgtm label Jul 1, 2023

ti-chi-bot bot merged commit d5ff0ad into pingcap:master Jul 1, 2023
5 checks passed

ti-chi-bot mentioned this pull request Jul 4, 2023

pkg: add 2 operator related tags to restored ebs volume (#5104) #5139

Merged

10 tasks

csuzhangxc pushed a commit that referenced this pull request Jul 4, 2023

pkg: add 2 operator related tags to restored ebs volume (#5104) (#5139)

dc52f41

Signed-off-by: BornChanger <[email protected]> Co-authored-by: BornChanger <[email protected]>

BornChanger added the area/ebs-br label Jul 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pkg: add 2 operator related tags to restored ebs volume #5104

pkg: add 2 operator related tags to restored ebs volume #5104

BornChanger commented Jun 28, 2023

BornChanger commented Jun 28, 2023

ti-chi-bot bot commented Jun 28, 2023

codecov-commenter commented Jun 28, 2023 •

edited

Loading

BornChanger commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

BornChanger commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

BornChanger commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jul 4, 2023

ti-chi-bot bot commented Jul 4, 2023

ti-chi-bot commented Jul 4, 2023

pkg: add 2 operator related tags to restored ebs volume #5104

pkg: add 2 operator related tags to restored ebs volume #5104

Conversation

BornChanger commented Jun 28, 2023

What problem does this PR solve?

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

BornChanger commented Jun 28, 2023

ti-chi-bot bot commented Jun 28, 2023

codecov-commenter commented Jun 28, 2023 • edited Loading

Codecov Report

BornChanger commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

BornChanger commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

BornChanger commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

ti-chi-bot bot commented Jun 29, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

[LGTM Timeline notifier]

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

ti-chi-bot bot commented Jun 30, 2023

BornChanger commented Jul 4, 2023

ti-chi-bot bot commented Jul 4, 2023

ti-chi-bot commented Jul 4, 2023

codecov-commenter commented Jun 28, 2023 •

edited

Loading