Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove tcp and http ports for tiflash >= 7.1.0 (#5075) #5078

Merged

Conversation

ti-chi-bot
Copy link
Member

This is an automated cherry-pick of #5075

What problem does this PR solve?

The tcp_port and http_port are deprecated in tiflash since v7.1.0.

What is changed and how does it work?

Remove those two ports for the corresponding versions.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.


@ti-chi-bot
Copy link
Contributor

ti-chi-bot bot commented Jun 20, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign sdojjy for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-bot
Copy link
Contributor

sre-bot commented Jun 20, 2023

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter
Copy link

Codecov Report

Merging #5078 (52e3b12) into release-1.5 (0dea819) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff              @@
##           release-1.5    #5078   +/-   ##
============================================
  Coverage        58.95%   58.96%           
============================================
  Files              228      228           
  Lines            26513    26516    +3     
============================================
+ Hits             15631    15635    +4     
+ Misses            9347     9346    -1     
  Partials          1535     1535           
Flag Coverage Δ
unittest 58.96% <100.00%> (+<0.01%) ⬆️

@csuzhangxc csuzhangxc merged commit a4c32ce into pingcap:release-1.5 Jun 20, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants