Fed backup schedule #5036

BornChanger · 2023-06-01T03:26:47Z

What problem does this PR solve?

Closes #5081

What is changed and how does it work?

This feature supports backup schedule support to EBS snapshot BR.

Code changes

Has Go code change
Has CI related scripts change

Tests

Unit test
E2E test
Manual test
No code

Side effects

Breaking backward compatibility
Other side effects:

Related changes

Need to cherry-pick to the release branch
Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

ti-chi-bot · 2023-06-01T03:26:50Z

[REVIEW NOTIFICATION]

This pull request has not been approved.

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

Signed-off-by: WangLe1321 <[email protected]>

Signed-off-by: BornChanger <[email protected]>

ti-chi-bot · 2023-06-13T13:21:09Z

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/run pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-13T13:23:37Z

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/run pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

BornChanger · 2023-06-13T13:23:48Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-06-13T13:23:51Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-13T13:23:51Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-13T13:24:24Z

/test pull-e2e-kind

ti-chi-bot · 2023-06-13T13:24:26Z

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-13T13:24:26Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-13T13:28:33Z

/test pull-e2e-kind-basic

ti-chi-bot · 2023-06-13T13:28:35Z

@BornChanger: The label(s) /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-13T13:28:35Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Signed-off-by: BornChanger <[email protected]>

BornChanger · 2023-06-13T13:54:14Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-basic

ti-chi-bot · 2023-06-13T13:54:16Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-br, /pull-e2e-kind-serial, /pull-e2e-kind-basic cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-13T13:54:16Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-br pull-e2e-kind-serial pull-e2e-kind-basic

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

codecov-commenter · 2023-06-13T14:31:16Z

Codecov Report

Merging #5036 (84188ec) into master (ebb269d) will decrease coverage by 20.14%.
The diff coverage is 0.00%.

Additional details and impacted files

@@             Coverage Diff             @@
##           master    #5036       +/-   ##
===========================================
- Coverage   57.42%   37.29%   -20.14%     
===========================================
  Files         246      217       -29     
  Lines       28587    28241      -346     
===========================================
- Hits        16417    10532     -5885     
- Misses      10577    16309     +5732     
+ Partials     1593     1400      -193

Flag	Coverage Δ
e2e	`37.29% <0.00%> (?)`
unittest	`?`

BornChanger · 2023-06-14T03:06:37Z

/test pull-e2e-kind pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-06-26T10:21:33Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: BornChanger, csuzhangxc, WangLe1321

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~OWNERS~~ [BornChanger,WangLe1321,csuzhangxc]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

BornChanger · 2023-06-26T10:22:58Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

ti-chi-bot · 2023-06-26T10:23:00Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes, /pull-e2e-kind-basic, /pull-e2e-kind-br, /pull-e2e-kind-serial cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-26T10:23:00Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes pull-e2e-kind-basic pull-e2e-kind-br pull-e2e-kind-serial

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-26T12:00:59Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-06-26T12:01:02Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-26T12:01:02Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-26T13:19:40Z

/test pull-e2e-kind

ti-chi-bot · 2023-06-26T13:19:42Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ti-chi-bot · 2023-06-26T13:19:42Z

@BornChanger: The label(s) /pull-e2e-kind cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

BornChanger · 2023-06-26T14:48:30Z

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-06-26T14:48:32Z

@BornChanger: The label(s) /pull-e2e-kind, /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-26T14:48:32Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-06-26T16:11:26Z

/test pull-e2e-kind-across-kubernetes

ti-chi-bot · 2023-06-26T16:11:27Z

@BornChanger: The label(s) /pull-e2e-kind-across-kubernetes cannot be applied, because the repository doesn't have them.

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-06-26T16:11:28Z

@BornChanger: No presubmit jobs available for pingcap/tidb-operator@master

In response to this:

/test pull-e2e-kind-across-kubernetes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

BornChanger · 2023-07-04T02:38:48Z

/cherry-pick release-1.5

ti-chi-bot · 2023-07-04T02:38:51Z

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-04T02:39:26Z

@BornChanger: new pull request created to branch release-1.5: #5133.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: ti-chi-bot <[email protected]>

BornChanger · 2023-07-04T03:55:01Z

/cherry-pick release-1.5

ti-chi-bot · 2023-07-04T03:55:03Z

@BornChanger: The label(s) /release-1.5 cannot be applied, because the repository doesn't have them.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

ti-chi-bot · 2023-07-04T03:55:38Z

@BornChanger: new pull request created to branch release-1.5: #5137.

In response to this:

/cherry-pick release-1.5

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

Signed-off-by: WangLe1321 <[email protected]> Signed-off-by: BornChanger <[email protected]> Co-authored-by: WangLe1321 <[email protected]> Co-authored-by: BornChanger <[email protected]>

ti-chi-bot bot requested review from csuzhangxc and liubog2008 June 1, 2023 03:27

BornChanger force-pushed the fed_backup_schedule branch from 2f7fed2 to a8ede94 Compare June 1, 2023 03:29

BornChanger mentioned this pull request Jun 1, 2023

EBS BR support to multiple k8s cluster TiDB #5003

Open

ti-chi-bot bot added needs-rebase size/XXL labels Jun 13, 2023

WangLe1321 and others added 4 commits June 13, 2023 20:51

br: implement federation volume backup controller

a55a967

Signed-off-by: WangLe1321 <[email protected]>

br: update backup member to status

ed7a108

Signed-off-by: WangLe1321 <[email protected]>

*: support ebs backup schedule

0443dec

Signed-off-by: BornChanger <[email protected]>

*: polish code and make ut pass

d3fee14

Signed-off-by: BornChanger <[email protected]>

BornChanger force-pushed the fed_backup_schedule branch from 90c45f3 to d3fee14 Compare June 13, 2023 12:56

*: fix license header format

e761776

Signed-off-by: BornChanger <[email protected]>

ti-chi-bot bot removed the needs-rebase label Jun 14, 2023

BornChanger added the lgtm label Jun 26, 2023

ti-chi-bot bot merged commit 9ae7cc6 into pingcap:master Jun 26, 2023
5 checks passed

BornChanger added the type/cherry-pick-for-release-1.5 label Jun 29, 2023

ti-chi-bot mentioned this pull request Jul 4, 2023

Fed backup schedule (#5036) #5133

Closed

10 tasks

ti-chi-bot pushed a commit to ti-chi-bot/tidb-operator that referenced this pull request Jul 4, 2023

This is an automated cherry-pick of pingcap#5036

bae6885

Signed-off-by: ti-chi-bot <[email protected]>

ti-chi-bot mentioned this pull request Jul 4, 2023

Fed backup schedule (#5036) #5137

Merged

10 tasks

BornChanger added the area/ebs-br label Jul 28, 2023

Fed backup schedule #5036

Fed backup schedule #5036

Conversation

BornChanger commented Jun 1, 2023 • edited Loading

What problem does this PR solve?

What is changed and how does it work?

Code changes

Tests

Side effects

Related changes

Release Notes

ti-chi-bot bot commented Jun 1, 2023

ti-chi-bot bot commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

BornChanger commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

BornChanger commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

BornChanger commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

BornChanger commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

ti-chi-bot bot commented Jun 13, 2023

codecov-commenter commented Jun 13, 2023 • edited Loading

Codecov Report

BornChanger commented Jun 14, 2023

ti-chi-bot bot commented Jun 26, 2023

BornChanger commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

BornChanger commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

BornChanger commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

BornChanger commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

BornChanger commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

ti-chi-bot bot commented Jun 26, 2023

BornChanger commented Jul 4, 2023

ti-chi-bot bot commented Jul 4, 2023

ti-chi-bot commented Jul 4, 2023

BornChanger commented Jul 4, 2023

ti-chi-bot bot commented Jul 4, 2023

ti-chi-bot commented Jul 4, 2023

BornChanger commented Jun 1, 2023 •

edited

Loading

codecov-commenter commented Jun 13, 2023 •

edited

Loading