lint

pingcap · Aug 30, 2024 · 47ad565 · 47ad565
1 parent e1cd583
commit 47ad565
Show file tree

Hide file tree

Showing 3 changed files with 0 additions and 4 deletions.
diff --git a/pkg/apis/pingcap/v1alpha1/backup.go b/pkg/apis/pingcap/v1alpha1/backup.go
@@ -354,7 +354,6 @@ func ParseLogBackupSubcommand(backup *Backup) LogSubCommandType {
 	}
 }
 
-// TODO: (Ris) move logic about truncate to elsewhere
 // IsLogBackupSubCommandOntheCondition return whether the log subcommand on the condition.
 func IsLogBackupSubCommandOntheCondition(backup *Backup, conditionType BackupConditionType) bool {
 	command := ParseLogBackupSubcommand(backup)
@@ -419,7 +418,6 @@ func IsLogBackupAlreadyStop(backup *Backup) bool {
 }
 
 // IsLogBackupAlreadyStop return whether log backup has already paused.
-//TODO: (Ris) deal with task stopped
 func IsLogBackupAlreadyPaused(backup *Backup) bool {
 	return backup.Spec.Mode == BackupModeLog && backup.Status.Phase == BackupPaused
 }

diff --git a/pkg/backup/backup/backup_manager.go b/pkg/backup/backup/backup_manager.go
@@ -161,7 +161,6 @@ func (bm *backupManager) syncBackupJob(backup *v1alpha1.Backup) error {
 	var job *batchv1.Job
 	var reason string
 	var updateStatus *controller.BackupUpdateStatus
-	//TODO: (Ris)modify the backupJobs
 	if job, updateStatus, reason, err = bm.makeBackupJob(backup); err != nil {
 		klog.Errorf("backup %s/%s create job %s failed, reason is %s, error %v.", ns, name, backupJobName, reason, err)
 		return err

diff --git a/pkg/controller/backup_status_updater.go b/pkg/controller/backup_status_updater.go
@@ -209,7 +209,6 @@ func updateSnapshotBackupStatus(backup *v1alpha1.Backup, condition *v1alpha1.Bac
 
 // updateLogBackupStatus update log backup status.
 // it will update both the log backup sub command status and the whole log backup status.
-//TODO: (Ris) add more states here
 func updateLogBackupStatus(backup *v1alpha1.Backup, condition *v1alpha1.BackupCondition, newStatus *BackupUpdateStatus) bool {
 	// update whole backup status
 	isWholeStatusUpdate := updateWholeLogBackupStatus(backup, condition, newStatus)