resource_manager: add background resource limit #1264
Conversation
glorv
requested review from
nolouch,
Connor1996 and
HuSharp
and removed request for
shihongzhi
|
can you paste the TiKV/TiDB related PR? |
Not submitted yet. |
|
@overvenus PTAL |
| // background task types. | ||
| repeated string job_types = 1; | ||
| // the percentage limit of total resource(cpu/io) that background tasks can use. | ||
| uint64 utilization_limit = 2; |
There was a problem hiding this comment.
Should we use separated limits for IO and CPU?
There was a problem hiding this comment.
Currently not, if both cpu and io are limited, the lower will take effect. BTW, in most cases, IO is not limited because it depends on the total IO quota which is not set by default.
|
@HuSharp: adding LGTM is restricted to approvers and reviewers in OWNERS files. In response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@Connor1996 @overvenus PTAL |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HuSharp, nolouch, overvenus The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
close #8616 update kvproto to include pingcap/kvproto#1264 to support set background task resource limit Signed-off-by: glorv <[email protected]> Co-authored-by: ti-chi-bot[bot] <108142056+ti-chi-bot[bot]@users.noreply.github.com>
No description provided.