code: write files without exec perm (#78)

* code: write files without exec perm Signed-off-by: xhe <[email protected]> Co-authored-by: tison <[email protected]>
pingcap · Aug 1, 2022 · 2eaa328 · 2eaa328
1 parent d190eaf
commit 2eaa328
Show file tree

Hide file tree

Showing 4 changed files with 13 additions and 13 deletions.
diff --git a/code/restorer.go b/code/restorer.go
@@ -112,7 +112,7 @@ func (r Restorer) Restore() error {
 				return fmt.Errorf("cannot merge modifications back automatically %s", patches[i].String())
 			}
 		}
-		if err := ioutil.WriteFile(filePath, []byte(pathedContent), os.ModePerm); err != nil {
+		if err := ioutil.WriteFile(filePath, []byte(pathedContent), 0644); err != nil {
 			return err
 		}
 		if err := os.Remove(originFileName); err != nil {
@@ -155,5 +155,5 @@ func %s(name string) string {
 	return  __failpointBindingCache.pkgpath + "/" + name
 }
 `, pak, extendPkgName)
-	return ioutil.WriteFile(bindingFile, []byte(bindingContent), os.ModePerm)
+	return ioutil.WriteFile(bindingFile, []byte(bindingContent), 0644)
 }
diff --git a/code/restorer_test.go b/code/restorer_test.go
@@ -197,11 +197,11 @@ func unittest() {
 	}
 
 	// Create temp files
-	err := os.MkdirAll(restorePath, os.ModePerm)
+	err := os.MkdirAll(restorePath, 0755)
 	require.NoError(t, err)
 	for _, cs := range cases {
 		original := filepath.Join(restorePath, cs.filepath)
-		err := ioutil.WriteFile(original, []byte(cs.original), os.ModePerm)
+		err := ioutil.WriteFile(original, []byte(cs.original), 0644)
 		require.NoError(t, err)
 	}
 
@@ -217,7 +217,7 @@ func unittest() {
 
 	for _, cs := range cases {
 		modified := filepath.Join(restorePath, cs.filepath)
-		err := ioutil.WriteFile(modified, []byte(cs.modified), os.ModePerm)
+		err := ioutil.WriteFile(modified, []byte(cs.modified), 0644)
 		require.NoError(t, err)
 	}
 
@@ -277,11 +277,11 @@ func unittest() {
 	}
 
 	// Create temp files
-	err := os.MkdirAll(restorePath, os.ModePerm)
+	err := os.MkdirAll(restorePath, 0755)
 	require.NoError(t, err)
 	for _, cs := range cases {
 		original := filepath.Join(restorePath, cs.filepath)
-		err := ioutil.WriteFile(original, []byte(cs.original), os.ModePerm)
+		err := ioutil.WriteFile(original, []byte(cs.original), 0644)
 		require.NoError(t, err)
 	}
 
@@ -297,7 +297,7 @@ func unittest() {
 
 	for _, cs := range cases {
 		modified := filepath.Join(restorePath, cs.filepath)
-		err := ioutil.WriteFile(modified, []byte(cs.modified), os.ModePerm)
+		err := ioutil.WriteFile(modified, []byte(cs.modified), 0644)
 		require.NoError(t, err)
 	}
 

diff --git a/code/rewriter.go b/code/rewriter.go
@@ -647,7 +647,7 @@ func (r *Rewriter) RewriteFile(path string) (err error) {
 		return err
 	}
 
-	newFile, err := os.OpenFile(path, os.O_TRUNC|os.O_CREATE|os.O_WRONLY, os.ModePerm)
+	newFile, err := os.OpenFile(path, os.O_TRUNC|os.O_CREATE|os.O_WRONLY, 0644)
 	if err != nil {
 		return err
 	}

diff --git a/code/rewriter_test.go b/code/rewriter_test.go
@@ -2438,11 +2438,11 @@ func unittest() {
 	}
 
 	// Create temp files
-	err := os.MkdirAll(rewritePath, os.ModePerm)
+	err := os.MkdirAll(rewritePath, 0755)
 	require.NoError(t, err)
 	for _, cs := range cases {
 		original := filepath.Join(rewritePath, cs.filepath)
-		err := ioutil.WriteFile(original, []byte(cs.original), os.ModePerm)
+		err := ioutil.WriteFile(original, []byte(cs.original), 0644)
 		require.NoError(t, err)
 	}
 
@@ -3600,11 +3600,11 @@ label:
 	}
 
 	// Create temp files
-	err := os.MkdirAll(rewritePath, os.ModePerm)
+	err := os.MkdirAll(rewritePath, 0755)
 	require.NoError(t, err)
 	for _, cs := range cases {
 		original := filepath.Join(rewritePath, cs.filepath)
-		err := ioutil.WriteFile(original, []byte(cs.original), os.ModePerm)
+		err := ioutil.WriteFile(original, []byte(cs.original), 0644)
 		require.NoError(t, err)
 	}