Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Fixed import, when users temp preview file is corrupt #414

Merged
merged 3 commits into from
Jul 19, 2024

Conversation

turbo-ele
Copy link
Contributor

If a users preview data is corrupt, the user is not able to open the importer anymore.

How to reproduce

  1. create a new import configuration
  2. upload csv with invalid encodings
  3. then the import config will crash and unable to open again.

Error Message:
Status: 500 | URL: /admin/pimcoredataimporter/dataobject/config/get Message: Malformed UTF-8 characters, possibly incorrectly encoded

@Corepex Corepex self-assigned this Jul 19, 2024
@Corepex Corepex changed the base branch from 1.8 to 1.9 July 19, 2024 07:04
@Corepex Corepex added this to the 1.9.2 milestone Jul 19, 2024
@Corepex
Copy link
Contributor

Corepex commented Jul 19, 2024

@turbo-ele, thanks for your PR - I rebased it on 1.9. Looks good to me 🚀

@Corepex Corepex merged commit a9d3d48 into pimcore:1.9 Jul 19, 2024
7 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jul 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants