Added support to create variants on object creation #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turbo-ele
force-pushed
the
feature/support-variants
branch
3 times, most recently
from
d594549
to
91b9ff6
Compare
turbo-ele
force-pushed
the
feature/support-variants
branch
4 times, most recently
from
2ac1474
to
5a33deb
Compare
|
can you please just add the english translation. all others are maintained via poeditor. thx very much. |
Co-authored-by: Sebastian Blank <[email protected]>
As the parent can be changed for variants this is now catched, as a variant cannot change its parent anymore.
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Qodana for PHPIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at [email protected]
|
As the parent can be changed for variants this is now catched, as a variant cannot change its parent anymore.
turbo-ele
force-pushed
the
feature/support-variants
branch
from
7ec2d92
to
91db3b3
Compare
turbo-ele
force-pushed
the
feature/support-variants
branch
from
b55dcf2
to
a5836ea
Compare
fashxp
requested changes
Feb 16, 2024
fashxp
requested changes
Mar 25, 2024
…importer into feature/support-variants
turbo-ele
commented
Mar 26, 2024
fashxp
reviewed
Mar 28, 2024
turbo-ele
force-pushed
the
feature/support-variants
branch
from
2227ac3
to
c457958
Compare
fashxp
approved these changes
Apr 16, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the import of variants on
Element CreationandElement Location Update, when using thefindParentlocation strategy.The type of the element will then be set to variant if all of the following conditions apply:
As Variantcheckbox is checkedAdditionally two more variant related checks were added:
variant