Fix missing backticks on column names #486
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Aidan Furlan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
|
Hi @epochlabs-dev thanks for your contribution. could you please sign the CLA? thanks! |
|
@epochlabs-dev Could you please sign the CLA? Thanks! |
|
@epochlabs-dev Also, could you please rebase the PR to 4.0 branch as this is a bug fix ? |
|
Closed in favour of #491 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When accessing the Customers list as an admin with restricted folder access, a MySQL/MariaDB syntax error is being thrown due to the 'key' column not being enclosed in backticks in CustomerManagementFrameworkBundle\Listing\Filter\Permission::addPermissionFilters().
This pull request adds backticks to the 'key' column, as well as 'path' for consistency.