Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Fixing PayPal without Drop-in #140

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Conversation

muccy
Copy link

@muccy muccy commented Oct 14, 2023

  • I fixed Android example project: now it compiles.
  • I changed the README in order to instruct about how to write a Manifest.xml that allows to request a PayPal payment without using drop-in
  • I fixed a bug during cancellation caused from strange SDK behaviour

Despite what's written in commit messages, I didn't update SDK version.

I'm still under the strong impression that paying with PayPal drop-in doesn't work, but I hadn't the time to fix also that problem (sorry)

@muccy
Copy link
Author

muccy commented Oct 17, 2023

I've just completed the PayPal request parameters on Android, too

@wwwdata
Copy link
Contributor

wwwdata commented Dec 14, 2023

Hm, this PR is open for a long time now :D Is this plugin still maintained?

Could you summarize again quickly why you made those changes? When I test out the Custom Activity with browser-switch it all works fine without your changes. But thanks a lot for the documentation of how to properly configure the Custom Activity.

It also still works after upgrading to the latest drop-in sdk without your changes #145

@muccy
Copy link
Author

muccy commented Dec 18, 2023

Hi,
I made these changes because I needed PayPay payment but not using drop-in. At that time, Android app displayed a blank activity and then was not able to process the payment.
I don't know if upgrading fixes all the problems now. Maybe I'll try, maybe not because the app that uses these changes is already in production for thousands of people. Thanks a lot for the info

wwwdata added a commit to HMobileClub/flutter-braintree that referenced this pull request Dec 22, 2023
@wwwdata
Copy link
Contributor

wwwdata commented Dec 22, 2023

Ok, I am also using your PR now with the latest drop-in version from Braintree. I had some issues/crashes before on some devices and your changes fixed them for me.

Let's hope that some day this will be merged in.

HMobileClub pushed a commit to HMobileClub/flutter-braintree that referenced this pull request Jun 17, 2024
…lection, meta, material_color_utilities, and others
… 13.0 across various files for improved compatibility
…nd 9.10.1 for enhanced functionality and stability
… 3.0.0 for enhanced compatibility and performance
…d Braintree SDK to 5.23.0 for improved compatibility and performance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants