Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow setting startType for documenting realizations #28

Merged
merged 2 commits into from
Jan 15, 2024

Conversation

fbenke-pik
Copy link
Contributor

@fbenke-pik fbenke-pik commented Jan 13, 2024

Motivation:

Currently, all gms files in realizations of REMIND are prepended with the equations identifier, which results in automatic inclusion of comments and equations in the goxygen documentation. This implicit approach has led to confusion among REMIND developers. In REMIND, we only want to include equations when stated explicitly by the equations identifier.

Therefore, we would like allow passing the parameter startType for documenting realizations when calling goxygen (defaults to "equations", which means current behavior). For REMIND, we will simply set it to NULL.

Copy link

codecov bot commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8cf529f) 93.89% compared to head (daefb43) 93.89%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   93.89%   93.89%           
=======================================
  Files          19       19           
  Lines         753      754    +1     
=======================================
+ Hits          707      708    +1     
  Misses         46       46           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tscheypidi
Copy link
Member

I think it would be more flexible and perhaps also more intuitive if you would just pass through the start_type argument. Ìn that case start_type = NULL would offer the wanted behavior.

If you agree with this solution it might also make sense to apply our camelcase linter rule and rename start_type to startType. If I am not mistaken that should still be possible at this stage without running into bigger compatibility issues as goxygen is usally the function which is being called externally.

@fbenke-pik
Copy link
Contributor Author

@tscheypidi I have made the requested adjustment. Please take a look again.

Copy link
Member

@tscheypidi tscheypidi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, thanks!

@fbenke-pik fbenke-pik changed the title introduce optional parameter autoDocumentRealizations allow setting startType for documenting realizations Jan 15, 2024
@fbenke-pik fbenke-pik merged commit 3f566c7 into pik-piam:master Jan 15, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants