Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Docker build #30

Merged
merged 3 commits into from
Mar 1, 2024
Merged

Add Docker build #30

merged 3 commits into from
Mar 1, 2024

Conversation

pfxuan
Copy link
Collaborator

@pfxuan pfxuan commented Mar 1, 2024

This PR reuses the existing ubuntu CI build logic to build local or remote docker images across different setup.

@pfxuan pfxuan mentioned this pull request Mar 1, 2024
@pierotofy
Copy link
Owner

Nice!! Love the fact that there's variables to control the lib/ubuntu version. Thanks for the PR @pfxuan !

@pierotofy pierotofy merged commit 04ed7fb into pierotofy:main Mar 1, 2024
20 checks passed
@pfxuan
Copy link
Collaborator Author

pfxuan commented Mar 1, 2024

@pierotofy Thank you for your help and support. Looking forward to see the next move for ODM + OpenSplat.

@parkerlreed
Copy link

parkerlreed commented Mar 14, 2024

I tried the ROCm dockerfile through podman and while seemingly creating the image successfully after setting up all the deps, it doesn't seem to compile the final binary.

The README doesn't really say anything after running the setup of how to run through Docker.

Is there anything special for that?

EDIT: Gist https://gist.github.com/parkerlreed/f123f824bd436c2989b1d00a04c12ed5

@pierotofy
Copy link
Owner

I think the Dockerfile.rocm file is missing the build commands (everything else should be there though).

https://github.com/pierotofy/OpenSplat/blob/main/Dockerfile#L46

vs.

https://github.com/pierotofy/OpenSplat/blob/main/Dockerfile.rocm#L70

@pfxuan might have more insights.

@pfxuan
Copy link
Collaborator Author

pfxuan commented Mar 15, 2024

Good catch. Dockerfile.rocm includes the full version of ROCm/HIP build environment but is missing the actual compile and build part. It should be very similar to this step. I'll probably add it from the next PR with an extra ROCm 6.0.2 support:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants