Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update base.py #460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update base.py #460

wants to merge 1 commit into from

Conversation

pop2pop3
Copy link

fix: New AppleID Auth with SIRP

Inspired by the work from @iowk after fixing the authentication of icloudpd: icloud-photos-downloader/icloud_photos_downloader@4bcb2ac#diff-f2270f557e6afedd3e082f4dd8478d1c96dea051d6ea2e5b1229c0bb58d3d7f4R339

Breaking change

Proposed change

Type of change

  • Dependency upgrade
  • [x ] Bugfix (non-breaking change which fixes an issue)
  • New service (thank you!)
  • New feature (which adds functionality to an existing service)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests
  • Documentation or code sample

Example of code:

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:

Checklist

  • [x ] The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

  • Documentation added/updated to README

fix: New AppleID Auth with SIRP

Inspired by the work from @iowk after fixing the authentication of `icloudpd`:
icloud-photos-downloader/icloud_photos_downloader@4bcb2ac#diff-f2270f557e6afedd3e082f4dd8478d1c96dea051d6ea2e5b1229c0bb58d3d7f4R339
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant