Move endpoints of Chinese iCloud account to icloud.com.cn #383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great PR! Really solved my problem 😭. But I suggest set |
|
Oh my bad. Now it's fixed and default to 0. |
|
I need this PR. Has this project been deprecated? the last commit was in 2022. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So since 2021/11/18, all Chinese iCloud accounts were moved from icloud.com to icloud.com.cn, which makes this whole amazing package(and some others, see icloud-photos-downloader/icloud_photos_downloader#392) not working.
To be specific,
PyiCloudSession.datais simply{'domainToUse': 'iCloud.com.cn'}now for all Chinese users.This PR introduce a fix, while not ideal because it uses an env var to toggle the switch, but is a non-breaking fix.
What do you think?