Give back changes from pyicloud_ipd fork #367
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently somehow maintaining "icloud photos downloader", icloudpd. That project relies on an old fork of pyicloud (pyicloud_ipd) by the program creator who added some slight changes/improvements to the behavior of pyicloud. IMHO these changes should have gone to pyicloud directly in the first place. This is my try to remove the necessity of the fork and port icloudphotosdownloader back to upstream version of pyicloud. I'm not the icloud or python expert, so please be merciful and help me putting this together.
Maybe it would make sense to put this in separate pull requests, but overall the changes are not soooo big, I think
Summary of the changes (as far as I can reconstruct):
Breaking change
It could be that changes 1 and 4 could break the use of this lib, but I'm not sure about that.
Proposed change
See above.
Type of change
Checklist
If user exposed functionality or configuration variables are added/changed: