Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PIA-1297: Regions flow design #76

Merged
merged 4 commits into from
Feb 9, 2024
Merged

PIA-1297: Regions flow design #76

merged 4 commits into from
Feb 9, 2024

Conversation

kp-laura-sempere
Copy link
Collaborator

@kp-laura-sempere kp-laura-sempere commented Feb 9, 2024 •
edited
Loading

  • Apply final designs on the Regions selection flow
  • Added all the Colors from the PIA tvOs Colors design guide -> The Colors are added as Colors assets (so it is easier to set the Light/Dark mode for each of them) and then they are defined in the Colors+SwiftUI file. The name used for each color is the same as the name used in Figma by the design team wit the pia_ prefix for each Color.

@kp-laura-sempere kp-laura-sempere marked this pull request as ready for review February 9, 2024 09:27
kp-said-rehouni
kp-said-rehouni approved these changes Feb 9, 2024
View reviewed changes
Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job @kp-laura-sempere!

@kp-laura-sempere kp-laura-sempere merged commit 27bf111 into master Feb 9, 2024
1 check failed
@kp-laura-sempere kp-laura-sempere deleted the PIA-1297_regions_screen_design branch February 9, 2024 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kp-said-rehouni kp-said-rehouni kp-said-rehouni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kp-laura-sempere @kp-said-rehouni