PIA-1003: Sort and filter servers list by favorite and recommended #70
Conversation
kp-laura-sempere
force-pushed
the
PIA-1003_regionslist_sorting
branch
6 times, most recently
from
e1fb395
to
e916d98
Compare
There was a problem hiding this comment.
Great job @kp-laura-sempere! Just a couple of comments that we can discuss tomorrow in a session.
| } | ||
| } | ||
|
|
||
| extension Client: ClientType { |
There was a problem hiding this comment.
I think I have not seen it being used and we already have ClientTypeImpl, do we need to make it conform to the procotol?
There was a problem hiding this comment.
Right, I created it to do the refresh latency but we are not using it.
I will remove it and then create a ticket to handle the refresh latency when needed
| } | ||
| } | ||
|
|
||
| private func refreshRegionsList() { |
There was a problem hiding this comment.
It seems that this ViewModel is probably doing many things, maybe we can break it down a bit, what do you think?
There was a problem hiding this comment.
Thanks @kp-said-rehouni ,
Yes, the thing is that we need to perform a lot of things from the regions list: add and remove to favorites, sorting by name and by recommended and search.
I created various UseCases to handle getting the servers list and also adding and removing from favorites. And this VM makes use of those use cases to do that. But in terms of sorting, filtering and searching (which it's another kind of filtering), not sure how we can split it out of this VM.
Do you have any suggestions? I will have another look and see if I can think of ways to do it
kp-laura-sempere
force-pushed
the
PIA-1003_regionslist_sorting
branch
from
d776e79
to
1568738
Compare
kp-laura-sempere
force-pushed
the
PIA-1003_regionslist_sorting
branch
from
e434530
to
56c93d5
Compare
This PR includes search, sort and filter functionatities: