-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PIA-1177: Integrate VPN profile installing in App flow #61
PIA-1177: Integrate VPN profile installing in App flow #61
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me @kp-said-rehouni
Since we will have some conflicts here after merging #60, I have left a couple of comments where you would have to make small tweaks after the merge
VPNConfigurationInstallingFactory.makeVPNConfigurationInstallingView() | ||
.withOnboardingRoutes() | ||
case .activated: | ||
DashboardFactory.makeDashboardView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge first #60, then here you would have to replace this line with:
UserActivatedContainerFactory.makeUSerActivatedContainerView()
PIA VPN-tvOS/Navigation/Routes.swift
Outdated
case .installVPNProfile: | ||
VPNConfigurationInstallingFactory.makeVPNConfigurationInstallingView() | ||
case .dashboard: | ||
DashboardFactory.makeDashboardView() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we merge first #60, then you would probably have to replace this line with:
UserActivatedContainerFactory.makeUSerActivatedContainerView()
6b15fff
to
d0017f2
Compare
d0017f2
to
95835fc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @kp-said-rehouni 🚀
Summary
This PR integrates the installing of VPN profile in the App flow.
The approach is based on this ADR.