PIA-1177: Integrate VPN profile installing in App flow #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Looks great to me @kp-said-rehouni
Since we will have some conflicts here after merging #60, I have left a couple of comments where you would have to make small tweaks after the merge
| VPNConfigurationInstallingFactory.makeVPNConfigurationInstallingView() | ||
| .withOnboardingRoutes() | ||
| case .activated: | ||
| DashboardFactory.makeDashboardView() |
There was a problem hiding this comment.
If we merge first #60, then here you would have to replace this line with:
UserActivatedContainerFactory.makeUSerActivatedContainerView()
PIA VPN-tvOS/Navigation/Routes.swift
Outdated
| case .installVPNProfile: | ||
| VPNConfigurationInstallingFactory.makeVPNConfigurationInstallingView() | ||
| case .dashboard: | ||
| DashboardFactory.makeDashboardView() |
There was a problem hiding this comment.
If we merge first #60, then you would probably have to replace this line with:
UserActivatedContainerFactory.makeUSerActivatedContainerView()
kp-said-rehouni
force-pushed
the
PIA-1177_integrate_vpn_profile_installing_flow
branch
from
6b15fff
to
d0017f2
Compare
kp-said-rehouni
force-pushed
the
PIA-1177_integrate_vpn_profile_installing_flow
branch
from
d0017f2
to
95835fc
Compare
kp-laura-sempere
approved these changes
Jan 16, 2024
kp-said-rehouni
deleted the
PIA-1177_integrate_vpn_profile_installing_flow
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR integrates the installing of VPN profile in the App flow.
The approach is based on this ADR.