PIA-987: Side Menu Tests #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-geneva-parayno
requested review from
kp-laura-sempere,
kp-said-rehouni and
kp-ruth-o
There was a problem hiding this comment.
@xv-geneva-parayno it looks good to me
There are a couple of comments raised by GitHubActions in the PR that are pointing to expectations that are not met in a couple of tests, even though the code has not been touched in this PR.
Do you know if this is due to CI flakiness? Do you have the same in your local machine?
|
@xv-geneva-parayno there are also a couple of conflicts in the PR. Let me know if you need help with the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Side Menu Tests