Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIA-988: Dedicated IP Tests #57

Merged
merged 1 commit into from
Jan 9, 2024
Merged

Conversation

kp-geneva-parayno
Copy link
Contributor

Added Dedicated IP Tests;
Optimised elements and methods on test screen classes;
Added Dedicated IP Token on env variables

Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job @xv-geneva-parayno!

@kp-geneva-parayno kp-geneva-parayno merged commit 28d3363 into master Jan 9, 2024
1 check failed
@kp-geneva-parayno kp-geneva-parayno deleted the PIA-988_DedicatedIPTests branch January 9, 2024 08:22
Copy link
Collaborator

@kp-laura-sempere kp-laura-sempere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job Geneva!
Good call adding the waitForExistence on the different elements to make the tests more stable 👍

It looks good to me for merging, I just added a comment on a line that GitHubActions seem to find an error. Let me know your thoughts

app.navigateToHome()
app.navigateToRegionSelection()
let firstRegion = app.getRegionList().staticTexts["DEDICATED IP"]
expect(firstRegion.staticTexts["DEDICATED IP"].waitForExistence(timeout: app.defaultTimeout)).to(beTrue())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that this line is failing in CI? 🤔 (As the comment below from GitHubActions suggests)
Does this pass on your local machine?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants