PIA-888: VPNConfiguration profile installation #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-said-rehouni
force-pushed
the
PIA-888_vpn_profile_screen
branch
from
949c7d3
to
da4aa33
Compare
kp-laura-sempere
approved these changes
Jan 8, 2024
| var body: some View { | ||
| VStack { | ||
| VStack { | ||
| Text("PIA needs access to your VPN profiles to secure your traffic.") |
There was a problem hiding this comment.
No need to do it in this PR, can be done in a later one:
We should probably add all the localizable strings into the tvOS target and use directly the translated strings, what do you think?
There was a problem hiding this comment.
Thanks @kp-laura-sempere!
Will create a ticket for this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the VPNConfiguration profile installation for tvOS.
It contains the functionality and also some unit tests to verify the behaviour.