PIA-882: Login feature for tvOS #44
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kp-said-rehouni
requested review from
kp-laura-sempere,
kp-juan-docal and
kp-geneva-parayno
PIA VPN-tvOS/Login/Domain/Use cases/LoginWithCredentialsUseCase.swift
Outdated
Show resolved
Hide resolved
kp-said-rehouni
force-pushed
the
PIA-882_tvos_sign_in_ui
branch
from
8ce2fc4
to
57ac26a
Compare
kp-juan-docal
approved these changes
Dec 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the Login screen to PIA tvOS. It includes all the different layers involved:
LoginViewModelexposes a status property in order to validate the logic when unit testing since the screen does not navigate when the operations was successful. This property will be taken care of once we tackle the navigation to the next screen.Tests are composed mainly by unit tests. There are also a couple of integration tests that are mocking the login provider which is a bridge to PIALibrary's
DefaultAccountProvider. These tests are responsible of testing the integration between the all the different components on presentation and domain layers.Error handling and proper design will be tackled in a different PR.
Architecture