Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PIA-908: VPNServerList Tests #39

Merged
merged 2 commits into from
Nov 23, 2023
Merged

Conversation

kp-geneva-parayno
Copy link
Contributor

Summary

Added VPNServerListTests, enhanced existing screens and tests

This PR fixes/implements the following bugs/features

  • Bug 1
  • Bug 2
  • Feature 1
  • Feature 2
  • Breaking changes

Explain the motivation for making this change. What existing problem does the pull request solve?

Test plan (required)

Demonstrate the code is solid. Example: The exact commands you ran and their output, screenshots / videos if the pull request changes UI.

Code formatting

Closing issues

Fixes #

Copy link
Collaborator

@kp-said-rehouni kp-said-rehouni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Great job @xv-geneva-parayno!

@kp-geneva-parayno kp-geneva-parayno merged commit 4742c67 into master Nov 23, 2023
1 check failed
@kp-geneva-parayno kp-geneva-parayno deleted the PIA-908_ServerListTests branch November 23, 2023 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants