Skip to content

Commit

Permalink
PIA-906: Xcode14 compatibility (#42)
Browse files Browse the repository at this point in the history
* PIA-906: Set XCode project compatible with XCode 14

* PIA-906: Build iOS app with XCode 14

* PIA-906: Update simulator device for automated tests

* PIA-906: Update CI runner for build and test worflow on pull request
  • Loading branch information
kp-laura-sempere authored Nov 28, 2023
1 parent f64291a commit 4eb986d
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 9 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/pull_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,6 @@ jobs:
git config --global url."https://${{ secrets.ORG_GITHUB_USERNAME }}:${{ secrets.ORG_GITHUB_TOKEN }}@github.com/".insteadOf "[email protected]:"
- uses: actions/checkout@v3

- name: Select XCode version
run: sudo xcode-select -s /Applications/Xcode_15.0.app

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand All @@ -35,5 +32,6 @@ jobs:

- name: Run e2e tests
run: bundle exec fastlane e2e_tests
timeout-minutes: 45


2 changes: 1 addition & 1 deletion .github/workflows/testflight_deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ jobs:
- uses: actions/checkout@v3

- name: Select XCode version
run: sudo xcode-select -s /Applications/Xcode_15.0.app
run: sudo xcode-select -s /Applications/Xcode_14.3.1.app

- name: Set up Ruby
uses: ruby/setup-ruby@v1
Expand Down
8 changes: 4 additions & 4 deletions PIA VPN.xcodeproj/project.pbxproj
Original file line number Diff line number Diff line change
Expand Up @@ -3412,7 +3412,7 @@
"$(inherited)",
"$(SRCROOT)",
);
MARKETING_VERSION = 3.23.4;
MARKETING_VERSION = 3.23.5;
PRODUCT_BUNDLE_IDENTIFIER = "com.privateinternetaccess.ios.PIA-VPN";
PRODUCT_MODULE_NAME = PIA_VPN_dev;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -3456,7 +3456,7 @@
"$(inherited)",
"$(SRCROOT)",
);
MARKETING_VERSION = 3.23.4;
MARKETING_VERSION = 3.23.5;
PRODUCT_BUNDLE_IDENTIFIER = "com.privateinternetaccess.ios.PIA-VPN";
PRODUCT_MODULE_NAME = PIA_VPN_dev;
PRODUCT_NAME = "$(TARGET_NAME)";
Expand Down Expand Up @@ -3746,7 +3746,7 @@
"$(inherited)",
"$(SRCROOT)",
);
MARKETING_VERSION = 3.23.4;
MARKETING_VERSION = 3.23.5;
PRODUCT_BUNDLE_IDENTIFIER = "com.privateinternetaccess.ios.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "match Development com.privateinternetaccess.ios.PIA-VPN";
Expand Down Expand Up @@ -3787,7 +3787,7 @@
"$(inherited)",
"$(SRCROOT)",
);
MARKETING_VERSION = 3.23.4;
MARKETING_VERSION = 3.23.5;
PRODUCT_BUNDLE_IDENTIFIER = "com.privateinternetaccess.ios.$(PRODUCT_NAME:rfc1034identifier)";
PRODUCT_NAME = "$(TARGET_NAME)";
PROVISIONING_PROFILE_SPECIFIER = "match AppStore com.privateinternetaccess.ios.PIA-VPN";
Expand Down
2 changes: 1 addition & 1 deletion fastlane/Fastfile
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ platform :ios do
run_tests(
scheme: "PIA VPN dev",
testplan: "PIA-VPN-e2e-simulator",
devices: ["iPhone 15"],
devices: ["iPhone 14"],
prelaunch_simulator: true,
test_without_building: true
)
Expand Down

0 comments on commit 4eb986d

Please sign in to comment.