Fix feature tests #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylewillmon
force-pushed
the
feature-tests
branch
from
2596976
to
616e019
Compare
Using `--no-default-features` on the workspace does not work as expected because the `purl_test` and `xtask` crates depend on certain features of the `purl` crate. So with feature unification, the `purl` crate is built with those features **enabled**. To resolve this and simplify the tests, this patch switches the default and minimal tests to only test the `purl` crate itself. The "Full" test is left to test the entire workspace with code coverage. This technically leaves open the possibility that `purl_test` or `xtask` may not successfully build with default features... But since those are test and development crates, I'm not actually concerned.
`PackageType` is only available with the `package-type` feature. So it's best to avoid it in unrelated doctests. Otherwise, they will fail when run without default features.
kylewillmon
force-pushed
the
feature-tests
branch
from
616e019
to
5e06915
Compare
matt-phylum
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
See related issue and individual commit messages for details.