Add namespace support to Linux sandbox #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous Linux sandbox would allow for access of abstract namespace sockets and handled network sandboxing through fragile seccomp rules. To both simplify the code and improve our sandboxing, this patch introduces the usage of Linux namespaces to both clear the abstract namespace and create a network namespace. It is now necessary to always lock down the sandbox in a newly created process, since user namespaces cannot be created from multi-threaded applications and require writing to `/proc/self/*id_map` exactly once (every following write from the same process is a permission error). This patch completely removes all seccomp code, however some part of it might still be useful for future sandboxing improvements.
This fixes issues where network sandboxing would cause failures when seccomp is supported while the `unshare` syscall is blocked (i.e. docker).
kylewillmon
requested changes
Sep 14, 2023
kylewillmon
requested changes
Sep 14, 2023
kylewillmon
approved these changes
Sep 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Linux sandbox would allow for access of abstract namespace sockets and handled network sandboxing through fragile seccomp rules.
To both simplify the code and improve our sandboxing, this patch introduces the usage of Linux namespaces to both clear the abstract namespace and create a network namespace.
It is now necessary to always lock down the sandbox in a newly created process, since user namespaces cannot be created from multi-threaded applications and require writing to
/proc/self/*id_mapexactly once (every following write from the same process is a permission error).This patch completely removes all seccomp code, however some part of it might still be useful for future sandboxing improvements.