Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add links to our npmjs URL #144

Merged
merged 4 commits into from
Jul 3, 2024
Merged

Add links to our npmjs URL #144

merged 4 commits into from
Jul 3, 2024

Conversation

gaurav
Copy link
Member

@gaurav gaurav commented Jul 3, 2024

This PR adds links to our npmjs URL in several places:

  • To the README file as both a badge and a link, as well as the command line required to install it
  • To the CITATION.cff file -- I also passed this through cffinit and found a few formatting and typing issues, which I also fixed.

@gaurav gaurav requested a review from hlapp July 3, 2024 20:35
@gaurav gaurav marked this pull request as ready for review July 3, 2024 20:35
Copy link
Member

@hlapp hlapp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't aware one needs to quote all URLs and dates!

@gaurav
Copy link
Member Author

gaurav commented Jul 3, 2024

I wasn't aware one needs to quote all URLs and dates!

AFAIK you don't need to quote URLs, but dates get parsed as JSON dates which confuses cffinit. The date works as-is in GitHub, so let's see if it continues working after this change!

@gaurav gaurav merged commit 5923c82 into master Jul 3, 2024
4 checks passed
@gaurav gaurav deleted the add-links-to-npmjs branch July 3, 2024 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants